openstack/deb-python-sqlalchemy-utils
Code Issues Proposed changes

Added better relationship property handling

Browse Source
This commit is contained in:
Konsta Vesterinen
2013-09-29 19:28:21 +03:00
parent 7f699dd472
commit 084fb5e866
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sqlalchemy_utils/functions/sort_query.py
View File

@@ -95,6 +95,8 @@ class QuerySorter(object):
else: else:
expr = sort_expression(entity, property_.key) expr = sort_expression(entity, property_.key)
return expr return expr
else:
return
if isinstance(entity, AliasedInsp): if isinstance(entity, AliasedInsp):
entity = entity.entity entity = entity.entity

5
tests/test_sort_query.py
View File

@@ -109,6 +109,11 @@ class TestSortQuery(TestCase):
sorted_query = sort_query(query, '-article_count') sorted_query = sort_query(query, '-article_count')
assert 'article_count DESC' in str(sorted_query) assert 'article_count DESC' in str(sorted_query)
def test_relationship_property(self):
query = self.session.query(self.Category)
query = sort_query(query, 'articles')
assert 'ORDER BY' not in str(query)
def test_hybrid_property(self): def test_hybrid_property(self):
query = self.session.query(self.Category) query = self.session.query(self.Category)
query = sort_query(query, 'articles_count') query = sort_query(query, 'articles_count')