openstack/deb-python-sqlalchemy-utils
Code Issues Proposed changes

Refactored batch fetch

Browse Source
This commit is contained in:
Konsta Vesterinen
2013-09-18 15:08:27 +03:00
parent b1bb5b8f43
commit d49e8c8d5c
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sqlalchemy_utils/functions/batch_fetch.py
View File

@@ -223,7 +223,10 @@ class Fetcher(object):
def __init__(self, path): def __init__(self, path):
self.path = path self.path = path
self.prop = self.path.property self.prop = self.path.property
if self.prop.uselist:
self.parent_dict = defaultdict(list) self.parent_dict = defaultdict(list)
else:
self.parent_dict = defaultdict(lambda: None)
@property @property
def local_values_list(self): def local_values_list(self):
@@ -387,10 +390,6 @@ class ManyToManyFetcher(Fetcher):
class ManyToOneFetcher(Fetcher): class ManyToOneFetcher(Fetcher):
def __init__(self, path):
Fetcher.__init__(self, path)
self.parent_dict = defaultdict(lambda: None)
def append_entity(self, entity): def append_entity(self, entity):
#print 'appending entity ', entity, ' to key ', self.parent_key(entity) #print 'appending entity ', entity, ' to key ', self.parent_key(entity)
self.parent_dict[self.parent_key(entity)] = entity self.parent_dict[self.parent_key(entity)] = entity