openstack/deb-python-taskflow
Code Issues Proposed changes

Update Flow::__str__

Browse Source 
The current implementation seems a little cryptic so updating it
to clearly indicate the atom count.

Change-Id: I4f97e458a4b80e33b3d6348a3ef632398586ed47
This commit is contained in:
Manish Godara
2015-02-13 15:53:22 -08:00
parent 72a9c00625
commit 06ffceea77
4 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
taskflow/flow.py
View File

@@ -96,9 +96,8 @@ class Flow(object):
""" """
def __str__(self): def __str__(self):
lines = ["%s: %s" % (reflection.get_class_name(self), self.name)] return "%s: %s(len=%d)" % (reflection.get_class_name(self),
lines.append("%s" % (len(self))) self.name, len(self))
return "; ".join(lines)
@property @property
def provides(self): def provides(self):

2
taskflow/tests/unit/patterns/test_graph_flow.py
View File

@@ -37,7 +37,7 @@ class GraphFlowTest(test.TestCase):
self.assertEqual(f.requires, set()) self.assertEqual(f.requires, set())
self.assertEqual(f.provides, set()) self.assertEqual(f.provides, set())
expected = 'taskflow.patterns.graph_flow.Flow: test; 0' expected = 'taskflow.patterns.graph_flow.Flow: test(len=0)'
self.assertEqual(str(f), expected) self.assertEqual(str(f), expected)
def test_graph_flow_add_nothing(self): def test_graph_flow_add_nothing(self):

4
taskflow/tests/unit/patterns/test_linear_flow.py
View File

@@ -36,7 +36,7 @@ class LinearFlowTest(test.TestCase):
self.assertEqual(f.requires, set()) self.assertEqual(f.requires, set())
self.assertEqual(f.provides, set()) self.assertEqual(f.provides, set())
expected = 'taskflow.patterns.linear_flow.Flow: test; 0' expected = 'taskflow.patterns.linear_flow.Flow: test(len=0)'
self.assertEqual(str(f), expected) self.assertEqual(str(f), expected)
def test_linear_flow_add_nothing(self): def test_linear_flow_add_nothing(self):
@@ -107,7 +107,7 @@ class LinearFlowTest(test.TestCase):
(task2, task3, {'invariant': True}) (task2, task3, {'invariant': True})
]) ])
expected = 'taskflow.patterns.linear_flow.Flow: test; 3' expected = 'taskflow.patterns.linear_flow.Flow: test(len=3)'
self.assertEqual(str(f), expected) self.assertEqual(str(f), expected)
def test_linear_flow_with_retry(self): def test_linear_flow_with_retry(self):

2
taskflow/tests/unit/patterns/test_unordered_flow.py
View File

@@ -36,7 +36,7 @@ class UnorderedFlowTest(test.TestCase):
self.assertEqual(f.requires, set()) self.assertEqual(f.requires, set())
self.assertEqual(f.provides, set()) self.assertEqual(f.provides, set())
expected = 'taskflow.patterns.unordered_flow.Flow: test; 0' expected = 'taskflow.patterns.unordered_flow.Flow: test(len=0)'
self.assertEqual(str(f), expected) self.assertEqual(str(f), expected)
def test_unordered_flow_add_nothing(self): def test_unordered_flow_add_nothing(self):