From cf85dd0f61dcf402c42b3649b9ed449142a1ac56 Mon Sep 17 00:00:00 2001 From: Joshua Harlow Date: Mon, 24 Nov 2014 17:07:52 -0800 Subject: [PATCH] Remove default setting of 'mysql_traditional_mode' The sqlalchemy versions we are using/supporting (0.6+) have the detection of the mysql mode built-in so only activate the connect setting if we are somehow overriden by a user who knows what they are doing. Fixes bug 1396278 Change-Id: If2226d3e9f921a1c5f62a6727016fe86cd50a9b5 --- taskflow/persistence/backends/impl_sqlalchemy.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/taskflow/persistence/backends/impl_sqlalchemy.py b/taskflow/persistence/backends/impl_sqlalchemy.py index 4b12b782..2ab36662 100644 --- a/taskflow/persistence/backends/impl_sqlalchemy.py +++ b/taskflow/persistence/backends/impl_sqlalchemy.py @@ -257,8 +257,6 @@ class SQLAlchemyBackend(base.Backend): if _as_bool(conf.pop('checkout_ping', True)): sa.event.listen(engine, 'checkout', _ping_listener) mode = None - if _as_bool(conf.pop('mysql_traditional_mode', True)): - mode = 'TRADITIONAL' if 'mysql_sql_mode' in conf: mode = conf.pop('mysql_sql_mode') if mode is not None: