openstack/deb-python-taskflow
Code Issues Proposed changes

Merge "Allow a jobs posted book to be none by default"

Browse Source
This commit is contained in:
Jenkins
2014-08-14 11:54:04 +00:00
committed by Gerrit Code Review
parent 90df3d430f 52b43f3e2f
commit 1f6e1aa8e3
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
taskflow/jobs/backends/impl_zookeeper.py
View File

@@ -432,7 +432,7 @@ class ZookeeperJobBoard(jobboard.NotifyingJobBoard):
else: else:
child_proc(request) child_proc(request)
def post(self, name, book, details=None): def post(self, name, book=None, details=None):
def format_posting(job_uuid): def format_posting(job_uuid):
posting = { posting = {

10
taskflow/jobs/jobboard.py
View File

@@ -118,14 +118,14 @@ class JobBoard(object):
""" """
@abc.abstractmethod @abc.abstractmethod
def post(self, name, book, details=None): def post(self, name, book=None, details=None):
"""Atomically creates and posts a job to the jobboard. """Atomically creates and posts a job to the jobboard.
This posting allowing others to attempt to claim that job (and This posting allowing others to attempt to claim that job (and
subsequently work on that job). The contents of the provided logbook subsequently work on that job). The contents of the provided logbook,
must provide *enough* information for others to reference to details dictionary, or name (or a mix of these) must provide *enough*
construct & work on the desired entries that are contained in that information for consumers to reference to construct and perform that
logbook. jobs contained work (whatever it may be).
Once a job has been posted it can only be removed by consuming that Once a job has been posted it can only be removed by consuming that
job (after that job is claimed). Any entity can post/propose jobs job (after that job is claimed). Any entity can post/propose jobs