From 55d9baa7ff5c9310ed27db63893bea7bcbe38585 Mon Sep 17 00:00:00 2001 From: Joshua Harlow Date: Fri, 6 Dec 2013 20:04:01 -0800 Subject: [PATCH] Fix another instance of callback comparison Seems like I missed another instance of using the new 'is_same_callback' method instead of comparing callbacks directly via 'is' Partial-Bug: #1257550 Change-Id: I7be2647c9be2c97f6786637d3fce53640e31a3b8 --- taskflow/utils/misc.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/taskflow/utils/misc.py b/taskflow/utils/misc.py index 75a5daec..ab1e74d4 100644 --- a/taskflow/utils/misc.py +++ b/taskflow/utils/misc.py @@ -246,8 +246,8 @@ class TransitionNotifier(object): def register(self, state, callback, args=None, kwargs=None): assert isinstance(callback, collections.Callable) - for i, (cb, args, kwargs) in enumerate(self._listeners.get(state, [])): - if cb is callback: + for (cb, _args, _kwargs) in self._listeners.get(state, []): + if reflection.is_same_callback(cb, callback): raise ValueError("Callback %s already registered" % (callback)) if kwargs: for k in self.RESERVED_KEYS: