From b348354d21297028e99e22830bddf484c49e6fbd Mon Sep 17 00:00:00 2001
From: Joshua Harlow <harlowja@yahoo-inc.com>
Date: Mon, 30 Sep 2013 17:47:40 -0700
Subject: [PATCH] Cleanup unused states

Not all the states are actively being used in any of
the taskflow code, so instead of keeping them around
lets just clean them up.

Fixes: bug 1232168

Change-Id: Ife92febe70692638bca4551766769a903273513f
---
 taskflow/states.py                  | 11 +++--------
 taskflow/tests/unit/test_storage.py |  4 ++--
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/taskflow/states.py b/taskflow/states.py
index 0ec3d5c7..d35b48f3 100644
--- a/taskflow/states.py
+++ b/taskflow/states.py
@@ -26,24 +26,19 @@ UNCLAIMED = 'UNCLAIMED'
 
 # Flow states.
 FAILURE = FAILURE
-INTERRUPTED = 'INTERRUPTED'
 PENDING = 'PENDING'
-RESUMING = 'RESUMING'
 REVERTING = 'REVERTING'
 REVERTED = 'REVERTED'
 RUNNING = RUNNING
-STARTED = 'STARTED'
 SUCCESS = SUCCESS
-CANCELLED = 'CANCELLED'
-INCOMPLETE = 'INCOMPLETE'
 SUSPENDING = 'SUSPENDING'
 SUSPENDED = 'SUSPENDED'
 
 # Task states.
 FAILURE = FAILURE
-STARTED = STARTED
 SUCCESS = SUCCESS
-TIMED_OUT = 'TIMED_OUT'
-CANCELLED = CANCELLED
 REVERTED = REVERTED
 REVERTING = REVERTING
+
+# TODO(harlowja): use when we can timeout tasks??
+TIMED_OUT = 'TIMED_OUT'
diff --git a/taskflow/tests/unit/test_storage.py b/taskflow/tests/unit/test_storage.py
index 36888da0..ea2e88ff 100644
--- a/taskflow/tests/unit/test_storage.py
+++ b/taskflow/tests/unit/test_storage.py
@@ -176,11 +176,11 @@ class StorageTest(test.TestCase):
 
     def test_get_flow_state(self):
         lb, fd = p_utils.temporary_flow_detail(backend=self.backend)
-        fd.state = states.INTERRUPTED
+        fd.state = states.FAILURE
         with contextlib.closing(self.backend.get_connection()) as conn:
             fd.update(conn.update_flow_details(fd))
         s = storage.Storage(flow_detail=fd, backend=self.backend)
-        self.assertEquals(s.get_flow_state(), states.INTERRUPTED)
+        self.assertEquals(s.get_flow_state(), states.FAILURE)
 
     def test_set_and_get_flow_state(self):
         s = self._get_storage()