From 6e21e3192058f58e19596b7eb7c9cfa887bd49e2 Mon Sep 17 00:00:00 2001 From: Greg Hill Date: Thu, 2 Jun 2016 12:46:55 -0500 Subject: [PATCH] Make tests less dependent on transient state Having to update the endpoint count every time you add a test class is really obnoxious and leads to a ton of pointless rebasing. Now we just check that it finds at least the task it knows about and call that good. Change-Id: I96b8c6cd6cbc1fdc58dee4b18cab5699e3daa844 --- taskflow/tests/unit/worker_based/test_worker.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/taskflow/tests/unit/worker_based/test_worker.py b/taskflow/tests/unit/worker_based/test_worker.py index 498e3504..0e49a562 100644 --- a/taskflow/tests/unit/worker_based/test_worker.py +++ b/taskflow/tests/unit/worker_based/test_worker.py @@ -33,7 +33,6 @@ class TestWorker(test.MockTestCase): self.broker_url = 'test-url' self.exchange = 'test-exchange' self.topic = 'test-topic' - self.endpoint_count = 29 # patch classes self.executor_mock, self.executor_inst_mock = self.patchClass( @@ -159,7 +158,7 @@ class TestWorker(test.MockTestCase): def test_derive_endpoints_from_string_modules(self): endpoints = worker.Worker._derive_endpoints(['taskflow.tests.utils']) - self.assertEqual(self.endpoint_count, len(endpoints)) + assert any(e.name == self.task_name for e in endpoints) def test_derive_endpoints_from_string_non_existent_module(self): tasks = ['non.existent.module'] @@ -190,7 +189,7 @@ class TestWorker(test.MockTestCase): def test_derive_endpoints_from_modules(self): endpoints = worker.Worker._derive_endpoints([utils]) - self.assertEqual(self.endpoint_count, len(endpoints)) + assert any(e.name == self.task_name for e in endpoints) def test_derive_endpoints_unexpected_task_type(self): self.assertRaises(TypeError, worker.Worker._derive_endpoints, [111])