From c866318b3ed48945b8f184f201c10a6669badb41 Mon Sep 17 00:00:00 2001
From: "Ivan A. Melnikov" <imelnikov@griddynamics.com>
Date: Mon, 14 Oct 2013 16:01:25 +0400
Subject: [PATCH] Storage: add flow name and uuid properties

This commit adds flow_name and flow_uuid properties to storage.
We also add couple of unit tests for storage while we are at it.

Change-Id: I58e6fcf7e799d7a69d75eab4fdc40400c1dc488d
---
 taskflow/storage.py                 |  8 ++++++++
 taskflow/tests/unit/test_storage.py | 30 +++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+)

diff --git a/taskflow/storage.py b/taskflow/storage.py
index e7d3d871..ad9fd6db 100644
--- a/taskflow/storage.py
+++ b/taskflow/storage.py
@@ -83,6 +83,14 @@ class Storage(object):
         self._with_connection(self._save_flow_detail)
         self._with_connection(self._save_task_detail, task_detail=td)
 
+    @property
+    def flow_name(self):
+        return self._flowdetail.name
+
+    @property
+    def flow_uuid(self):
+        return self._flowdetail.uuid
+
     def _save_flow_detail(self, conn):
         # NOTE(harlowja): we need to update our contained flow detail if
         # the result of the update actually added more (aka another process
diff --git a/taskflow/tests/unit/test_storage.py b/taskflow/tests/unit/test_storage.py
index 014fd20a..c2019ab1 100644
--- a/taskflow/tests/unit/test_storage.py
+++ b/taskflow/tests/unit/test_storage.py
@@ -21,9 +21,11 @@ import mock
 
 from taskflow import exceptions
 from taskflow.persistence.backends import impl_memory
+from taskflow.persistence import logbook
 from taskflow import states
 from taskflow import storage
 from taskflow import test
+from taskflow.utils import misc
 from taskflow.utils import persistence_utils as p_utils
 
 
@@ -48,6 +50,12 @@ class StorageTest(test.TestCase):
         s.add_task('42', 'my task')
         self.assertEquals(s.get_uuid_by_name('my task'), '42')
 
+    def test_flow_name_and_uuid(self):
+        fd = logbook.FlowDetail(name='test-fd', uuid='aaaa')
+        s = storage.Storage(flow_detail=fd)
+        self.assertEquals(s.flow_name, 'test-fd')
+        self.assertEquals(s.flow_uuid, 'aaaa')
+
     def test_add_task(self):
         s = self._get_storage()
         s.add_task('42', 'my task')
@@ -79,6 +87,14 @@ class StorageTest(test.TestCase):
         self.assertEquals(s.get('42'), 5)
         self.assertEquals(s.get_task_state('42'), states.FAILURE)
 
+    def test_save_and_get_failure(self):
+        fail = misc.Failure(exc_info=(RuntimeError, RuntimeError(), None))
+        s = self._get_storage()
+        s.add_task('42', 'my task')
+        s.save('42', fail, states.FAILURE)
+        self.assertEquals(s.get('42'), fail)
+        self.assertEquals(s.get_task_state('42'), states.FAILURE)
+
     def test_get_non_existing_var(self):
         s = self._get_storage()
         s.add_task('42', 'my task')
@@ -114,6 +130,20 @@ class StorageTest(test.TestCase):
                                      "^Name 'xxx' is not mapped"):
             s.fetch('xxx')
 
+    def test_default_task_progress(self):
+        s = self._get_storage()
+        s.add_task('42', 'my task')
+        self.assertEquals(s.get_task_progress('42'), 0.0)
+        self.assertEquals(s.get_task_progress_details('42'), None)
+
+    def test_task_progress(self):
+        s = self._get_storage()
+        s.add_task('42', 'my task')
+        s.set_task_progress('42', 0.5, test_data=11)
+        self.assertEquals(s.get_task_progress('42'), 0.5)
+        self.assertEquals(s.get_task_progress_details('42'),
+                          {'test_data': 11})
+
     def test_fetch_result_not_ready(self):
         s = self._get_storage()
         s.add_task('42', 'my task')