openstack/deb-python-taskflow
Code Issues Proposed changes

Merge "Make the default file encoding a class constant with a docstring"

Browse Source
This commit is contained in:
Jenkins
2015-06-14 18:42:30 +00:00
committed by Gerrit Code Review
parent 1c036998ca deaf61caac
commit a6126941af
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
taskflow/persistence/backends/impl_dir.py
View File

@@ -60,6 +60,12 @@ class DirBackend(path_based.PathBasedBackend):
}
"""
DEFAULT_FILE_ENCODING = 'utf-8'
"""
Default encoding used when decoding or encoding files into or from
text/unicode into binary or binary into text/unicode.
"""
def __init__(self, conf):
super(DirBackend, self).__init__(conf)
max_cache_size = self._conf.get('max_cache_size')
@@ -71,7 +77,7 @@ class DirBackend(path_based.PathBasedBackend):
self.file_cache = cachetools.LRUCache(max_cache_size)
else:
self.file_cache = {}
self.encoding = self._conf.get('encoding', 'utf-8')
self.encoding = self._conf.get('encoding', self.DEFAULT_FILE_ENCODING)
if not self._path:
raise ValueError("Empty path is disallowed")
self._path = os.path.abspath(self._path)