openstack/deb-python-taskflow
Code Issues Proposed changes

Using assertIsNone() instead of assertIs(None, ..)

Browse Source 
Following OpenStack Style Guidelines[1]:
http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred
over assertEqual(None, ...) and assertIs(..,None).

Change-Id: I52ecf3f4945c4cb99f6350afca1c51d88b16bb8d
This commit is contained in:
qinchunhua
2016-10-10 04:43:03 -04:00
parent 50fba9c978
commit e68032929c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
taskflow/tests/unit/action_engine/test_compile.py
View File

@@ -599,7 +599,7 @@ class PatternCompileTest(test.TestCase):
self.assertIs(c2, g.node['b']['retry'])
self.assertIs(c2, g.node['c']['retry'])
self.assertIs(c1, g.node['c2']['retry'])
self.assertIs(None, g.node['c1'].get('retry'))
self.assertIsNone(g.node['c1'].get('retry'))
def test_retry_subflows_hierarchy(self):
c1 = retry.AlwaysRevert("c1")
@@ -624,4 +624,4 @@ class PatternCompileTest(test.TestCase):
self.assertIs(c1, g.node['d']['retry'])
self.assertIs(c1, g.node['b']['retry'])
self.assertIs(c1, g.node['c']['retry'])
self.assertIs(None, g.node['c1'].get('retry'))
self.assertIsNone(g.node['c1'].get('retry'))