openstack/deb-python-taskflow
Code Issues Proposed changes

Make failure formatter configurable for DynamicLoggingListener

Browse Source 
DynamicLoggingListener uses only formatters.FailureFormatter
to format errors. We should have API to pass formatter instance
to DynamicLoggingListener to make it more flexible.

Change-Id: I9658fbac97e4074b551a50d6016a92806a3636c1
Implements: blueprint dynamic-logging-listener-formatter-support
This commit is contained in:
Ivan Kolodyazhny
2016-09-07 13:03:37 +03:00
parent df10cb5acc
commit e8b1d58091
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
taskflow/listeners/logging.py
View File

@@ -111,7 +111,8 @@ class DynamicLoggingListener(base.Listener):
flow_listen_for=base.DEFAULT_LISTEN_FOR, flow_listen_for=base.DEFAULT_LISTEN_FOR,
retry_listen_for=base.DEFAULT_LISTEN_FOR, retry_listen_for=base.DEFAULT_LISTEN_FOR,
log=None, failure_level=logging.WARNING, log=None, failure_level=logging.WARNING,
level=logging.DEBUG, hide_inputs_outputs_of=()): level=logging.DEBUG, hide_inputs_outputs_of=(),
fail_formatter=None):
super(DynamicLoggingListener, self).__init__( super(DynamicLoggingListener, self).__init__(
engine, task_listen_for=task_listen_for, engine, task_listen_for=task_listen_for,
flow_listen_for=flow_listen_for, retry_listen_for=retry_listen_for) flow_listen_for=flow_listen_for, retry_listen_for=retry_listen_for)
@@ -129,8 +130,12 @@ class DynamicLoggingListener(base.Listener):
} }
self._hide_inputs_outputs_of = frozenset(hide_inputs_outputs_of) self._hide_inputs_outputs_of = frozenset(hide_inputs_outputs_of)
self._logger = misc.pick_first_not_none(log, self._LOGGER, LOG) self._logger = misc.pick_first_not_none(log, self._LOGGER, LOG)
if fail_formatter is None:
self._fail_formatter = formatters.FailureFormatter( self._fail_formatter = formatters.FailureFormatter(
self._engine, hide_inputs_outputs_of=self._hide_inputs_outputs_of) self._engine,
hide_inputs_outputs_of=self._hide_inputs_outputs_of)
else:
self._fail_formatter = fail_formatter
def _flow_receiver(self, state, details): def _flow_receiver(self, state, details):
"""Gets called on flow state changes.""" """Gets called on flow state changes."""