- Convert the various functions that take a task detail into
ones that take atom details (since this is now the generic
type they should take).
- Don't expose the detail type strings as part of the atom
detail api, leave those as private hidden strings and provide
conversion functions from string<->class instead.
- Have the logbook objects contain the following new methods
to reduce the dependence on persistence_utils to do the same.
- to_dict() which converts the current object into a dict
- from_dict() which converts the provided dict into a object
- merge() which merges a incoming objects data with the current
objects
- Have the persistence backends + storage + action engine use these
new methods instead of there current usage.
- Don't compare to logbook.RETRY_DETAIL or logbook.TASK_DETAIL since
python has the isinstance function just use it (ideally we should
fix the code so that this isn't even needed, usage of isinstance
means something is not designed/structured right).
- In storage tests we can't assume that failures will be non-lossy
since under certain backends when a failure is stored information
about the internally held exc_info is lost, so take this into
account when testing by using matches() where applicable.
Change-Id: Ie8a274cfd4cb4e64e87c355dc99d466d74a4e82c
64 lines
2.1 KiB
Python
64 lines
2.1 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright (C) 2012 Yahoo! Inc. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import contextlib
|
|
import time
|
|
|
|
from taskflow import task
|
|
from taskflow import test
|
|
|
|
import taskflow.engines
|
|
from taskflow.listeners import timing
|
|
from taskflow.patterns import linear_flow as lf
|
|
from taskflow.persistence.backends import impl_memory
|
|
from taskflow.utils import persistence_utils as p_utils
|
|
|
|
|
|
class SleepyTask(task.Task):
|
|
def __init__(self, name, sleep_for=0.0):
|
|
super(SleepyTask, self).__init__(name=name)
|
|
self._sleep_for = float(sleep_for)
|
|
|
|
def execute(self):
|
|
if self._sleep_for <= 0:
|
|
return
|
|
else:
|
|
time.sleep(self._sleep_for)
|
|
|
|
|
|
class TestDuration(test.TestCase):
|
|
def make_engine(self, flow, flow_detail, backend):
|
|
e = taskflow.engines.load(flow,
|
|
flow_detail=flow_detail,
|
|
backend=backend)
|
|
e.compile()
|
|
return e
|
|
|
|
def test_duration(self):
|
|
with contextlib.closing(impl_memory.MemoryBackend({})) as be:
|
|
flo = lf.Flow("test")
|
|
flo.add(SleepyTask("test-1", sleep_for=0.1))
|
|
(lb, fd) = p_utils.temporary_flow_detail(be)
|
|
e = self.make_engine(flo, fd, be)
|
|
with timing.TimingListener(e):
|
|
e.run()
|
|
t_uuid = e.storage.get_atom_uuid("test-1")
|
|
td = fd.find(t_uuid)
|
|
self.assertIsNotNone(td)
|
|
self.assertIsNotNone(td.meta)
|
|
self.assertIn('duration', td.meta)
|
|
self.assertGreaterEqual(0.1, td.meta['duration'])
|