- Convert the various functions that take a task detail into
ones that take atom details (since this is now the generic
type they should take).
- Don't expose the detail type strings as part of the atom
detail api, leave those as private hidden strings and provide
conversion functions from string<->class instead.
- Have the logbook objects contain the following new methods
to reduce the dependence on persistence_utils to do the same.
- to_dict() which converts the current object into a dict
- from_dict() which converts the provided dict into a object
- merge() which merges a incoming objects data with the current
objects
- Have the persistence backends + storage + action engine use these
new methods instead of there current usage.
- Don't compare to logbook.RETRY_DETAIL or logbook.TASK_DETAIL since
python has the isinstance function just use it (ideally we should
fix the code so that this isn't even needed, usage of isinstance
means something is not designed/structured right).
- In storage tests we can't assume that failures will be non-lossy
since under certain backends when a failure is stored information
about the internally held exc_info is lost, so take this into
account when testing by using matches() where applicable.
Change-Id: Ie8a274cfd4cb4e64e87c355dc99d466d74a4e82c
143 lines
4.9 KiB
Python
143 lines
4.9 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright (C) 2012 Yahoo! Inc. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import contextlib
|
|
|
|
from taskflow import task
|
|
from taskflow import test
|
|
|
|
import taskflow.engines
|
|
from taskflow.patterns import linear_flow as lf
|
|
from taskflow.persistence.backends import impl_memory
|
|
from taskflow.utils import persistence_utils as p_utils
|
|
|
|
|
|
class ProgressTask(task.Task):
|
|
def __init__(self, name, segments):
|
|
super(ProgressTask, self).__init__(name=name)
|
|
self._segments = segments
|
|
|
|
def execute(self):
|
|
if self._segments <= 0:
|
|
return
|
|
for i in range(1, self._segments):
|
|
progress = float(i) / self._segments
|
|
self.update_progress(progress)
|
|
|
|
|
|
class ProgressTaskWithDetails(task.Task):
|
|
def execute(self):
|
|
self.update_progress(0.5, test='test data', foo='bar')
|
|
|
|
|
|
class TestProgress(test.TestCase):
|
|
def _make_engine(self, flow, flow_detail=None, backend=None):
|
|
e = taskflow.engines.load(flow,
|
|
flow_detail=flow_detail,
|
|
backend=backend)
|
|
e.compile()
|
|
return e
|
|
|
|
def tearDown(self):
|
|
super(TestProgress, self).tearDown()
|
|
with contextlib.closing(impl_memory.MemoryBackend({})) as be:
|
|
with contextlib.closing(be.get_connection()) as conn:
|
|
conn.clear_all()
|
|
|
|
def test_sanity_progress(self):
|
|
fired_events = []
|
|
|
|
def notify_me(task, event_data, progress):
|
|
fired_events.append(progress)
|
|
|
|
ev_count = 5
|
|
t = ProgressTask("test", ev_count)
|
|
t.bind('update_progress', notify_me)
|
|
flo = lf.Flow("test")
|
|
flo.add(t)
|
|
e = self._make_engine(flo)
|
|
e.run()
|
|
self.assertEqual(ev_count + 1, len(fired_events))
|
|
self.assertEqual(1.0, fired_events[-1])
|
|
self.assertEqual(0.0, fired_events[0])
|
|
|
|
def test_no_segments_progress(self):
|
|
fired_events = []
|
|
|
|
def notify_me(task, event_data, progress):
|
|
fired_events.append(progress)
|
|
|
|
t = ProgressTask("test", 0)
|
|
t.bind('update_progress', notify_me)
|
|
flo = lf.Flow("test")
|
|
flo.add(t)
|
|
e = self._make_engine(flo)
|
|
e.run()
|
|
# 0.0 and 1.0 should be automatically fired
|
|
self.assertEqual(2, len(fired_events))
|
|
self.assertEqual(1.0, fired_events[-1])
|
|
self.assertEqual(0.0, fired_events[0])
|
|
|
|
def test_storage_progress(self):
|
|
with contextlib.closing(impl_memory.MemoryBackend({})) as be:
|
|
flo = lf.Flow("test")
|
|
flo.add(ProgressTask("test", 3))
|
|
b, fd = p_utils.temporary_flow_detail(be)
|
|
e = self._make_engine(flo, flow_detail=fd, backend=be)
|
|
e.run()
|
|
end_progress = e.storage.get_task_progress("test")
|
|
self.assertEqual(1.0, end_progress)
|
|
task_uuid = e.storage.get_atom_uuid("test")
|
|
td = fd.find(task_uuid)
|
|
self.assertEqual(1.0, td.meta['progress'])
|
|
self.assertFalse(td.meta['progress_details'])
|
|
|
|
def test_storage_progress_detail(self):
|
|
flo = ProgressTaskWithDetails("test")
|
|
e = self._make_engine(flo)
|
|
e.run()
|
|
end_progress = e.storage.get_task_progress("test")
|
|
self.assertEqual(1.0, end_progress)
|
|
end_details = e.storage.get_task_progress_details("test")
|
|
self.assertEqual(end_details.get('at_progress'), 0.5)
|
|
self.assertEqual(end_details.get('details'), {
|
|
'test': 'test data',
|
|
'foo': 'bar'
|
|
})
|
|
|
|
def test_dual_storage_progress(self):
|
|
fired_events = []
|
|
|
|
def notify_me(task, event_data, progress):
|
|
fired_events.append(progress)
|
|
|
|
with contextlib.closing(impl_memory.MemoryBackend({})) as be:
|
|
t = ProgressTask("test", 5)
|
|
t.bind('update_progress', notify_me)
|
|
flo = lf.Flow("test")
|
|
flo.add(t)
|
|
b, fd = p_utils.temporary_flow_detail(be)
|
|
e = self._make_engine(flo, flow_detail=fd, backend=be)
|
|
e.run()
|
|
|
|
end_progress = e.storage.get_task_progress("test")
|
|
self.assertEqual(1.0, end_progress)
|
|
task_uuid = e.storage.get_atom_uuid("test")
|
|
td = fd.find(task_uuid)
|
|
self.assertEqual(1.0, td.meta['progress'])
|
|
self.assertFalse(td.meta['progress_details'])
|
|
self.assertEqual(6, len(fired_events))
|