Instead of recreating a dispatcher in the server
and executor objects use a common dispatcher that
is shared between them. It will dispatch based on
the message type received into a provided dict of
dispatch handler callbacks.
It also can generically requeue messages and can
reject messages if they are missing key required
message properties ('type' in the current case).
Part of blueprint wbe-message-validation
Change-Id: I8320f4707183f36e6a69f0552cf62f99a5467b7e
78 lines
2.6 KiB
Python
78 lines
2.6 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright (C) 2014 Yahoo! Inc. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from kombu import message
|
|
import mock
|
|
|
|
from taskflow.engines.worker_based import dispatcher
|
|
from taskflow import test
|
|
|
|
|
|
def mock_acked_message(ack_ok=True, **kwargs):
|
|
msg = mock.create_autospec(message.Message, spec_set=True, instance=True,
|
|
channel=None, **kwargs)
|
|
|
|
def ack_side_effect(*args, **kwargs):
|
|
msg.acknowledged = True
|
|
|
|
if ack_ok:
|
|
msg.ack_log_error.side_effect = ack_side_effect
|
|
msg.acknowledged = False
|
|
return msg
|
|
|
|
|
|
class TestDispatcher(test.MockTestCase):
|
|
def test_creation(self):
|
|
on_hello = mock.MagicMock()
|
|
handlers = {'hello': on_hello}
|
|
dispatcher.TypeDispatcher(handlers)
|
|
|
|
def test_on_message(self):
|
|
on_hello = mock.MagicMock()
|
|
handlers = {'hello': on_hello}
|
|
d = dispatcher.TypeDispatcher(handlers)
|
|
msg = mock_acked_message(properties={'type': 'hello'})
|
|
d.on_message("", msg)
|
|
self.assertTrue(on_hello.called)
|
|
self.assertTrue(msg.ack_log_error.called)
|
|
self.assertTrue(msg.acknowledged)
|
|
|
|
def test_on_rejected_message(self):
|
|
d = dispatcher.TypeDispatcher({})
|
|
msg = mock_acked_message(properties={'type': 'hello'})
|
|
d.on_message("", msg)
|
|
self.assertTrue(msg.reject_log_error.called)
|
|
self.assertFalse(msg.acknowledged)
|
|
|
|
def test_on_requeue_message(self):
|
|
d = dispatcher.TypeDispatcher({})
|
|
d.add_requeue_filter(lambda data, message: True)
|
|
msg = mock_acked_message()
|
|
d.on_message("", msg)
|
|
self.assertTrue(msg.requeue.called)
|
|
self.assertFalse(msg.acknowledged)
|
|
|
|
def test_failed_ack(self):
|
|
on_hello = mock.MagicMock()
|
|
handlers = {'hello': on_hello}
|
|
d = dispatcher.TypeDispatcher(handlers)
|
|
msg = mock_acked_message(ack_ok=False,
|
|
properties={'type': 'hello'})
|
|
d.on_message("", msg)
|
|
self.assertTrue(msg.ack_log_error.called)
|
|
self.assertFalse(msg.acknowledged)
|
|
self.assertFalse(on_hello.called)
|