Files
deb-python-taskflow/taskflow/engines/action_engine/engine.py
Joshua Harlow 37295b71a9 Use the lock decorator and close/join the thread pool
When the thread pool is owned by the engine (when it
is not passed in) we should be careful and ensure that
we close the pool (this stops it from accepting new
work) and then join on the pool (this ensures that all
contained threads complete) to avoid resource leakage.

Change-Id: Icb6e0f8051c017458657b4ff8872d3af44565c18
Fixes: bug 1221382
2013-09-06 12:11:23 -07:00

202 lines
6.2 KiB
Python

# -*- coding: utf-8 -*-
# vim: tabstop=4 shiftwidth=4 softtabstop=4
# Copyright (C) 2012 Yahoo! Inc. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import threading
from multiprocessing import pool
from taskflow.engines.action_engine import parallel_action
from taskflow.engines.action_engine import seq_action
from taskflow.engines.action_engine import task_action
from taskflow.patterns import linear_flow as lf
from taskflow.patterns import unordered_flow as uf
from taskflow import decorators
from taskflow import exceptions as exc
from taskflow import states
from taskflow import storage as t_storage
from taskflow import task
from taskflow.utils import misc
class ActionEngine(object):
"""Generic action-based engine.
Converts the flow to recursive structure of actions.
"""
def __init__(self, flow, storage):
self._failures = []
self._root = None
self._flow = flow
self._lock = threading.RLock()
self.notifier = misc.TransitionNotifier()
self.task_notifier = misc.TransitionNotifier()
self.storage = storage
def _revert(self, current_failure):
self._change_state(states.REVERTING)
self._root.revert(self)
self._change_state(states.REVERTED)
self._change_state(states.FAILURE)
if self._failures:
if len(self._failures) == 1:
self._failures[0].reraise()
else:
exc_infos = [f.exc_info for f in self._failures]
raise exc.LinkedException.link(exc_infos)
else:
current_failure.reraise()
def _reset(self):
self._failures = []
@decorators.locked
def run(self):
self.compile()
self._reset()
self._change_state(states.RUNNING)
try:
self._root.execute(self)
except Exception:
self._revert(misc.Failure())
else:
self._change_state(states.SUCCESS)
def _change_state(self, state):
self.storage.set_flow_state(state)
details = dict(engine=self)
self.notifier.notify(state, details)
def on_task_state_change(self, task_action, state, result=None):
if isinstance(result, misc.Failure):
self._failures.append(result)
details = dict(engine=self,
task_name=task_action.name,
task_uuid=task_action.uuid,
result=result)
self.task_notifier.notify(state, details)
@decorators.locked
def compile(self):
if self._root is None:
translator = self.translator_cls(self)
self._root = translator.translate(self._flow)
class Translator(object):
def __init__(self, engine):
self.engine = engine
def _factory_map(self):
return []
def translate(self, pattern):
"""Translates the pattern into an engine runnable action"""
if isinstance(pattern, task.BaseTask):
# Wrap the task into something more useful.
return task_action.TaskAction(pattern, self.engine)
# Decompose the flow into something more useful:
for cls, factory in self._factory_map():
if isinstance(pattern, cls):
return factory(pattern)
raise TypeError('Unknown pattern type: %s (type %s)'
% (pattern, type(pattern)))
class SingleThreadedTranslator(Translator):
def _factory_map(self):
return [(lf.Flow, self._translate_sequential),
(uf.Flow, self._translate_sequential)]
def _translate_sequential(self, pattern):
action = seq_action.SequentialAction()
for p in pattern:
action.add(self.translate(p))
return action
class SingleThreadedActionEngine(ActionEngine):
translator_cls = SingleThreadedTranslator
def __init__(self, flow, flow_detail=None):
ActionEngine.__init__(self, flow,
storage=t_storage.Storage(flow_detail))
class MultiThreadedTranslator(Translator):
def _factory_map(self):
return [(lf.Flow, self._translate_sequential),
# unordered can be run in parallel
(uf.Flow, self._translate_parallel)]
def _translate_sequential(self, pattern):
action = seq_action.SequentialAction()
for p in pattern:
action.add(self.translate(p))
return action
def _translate_parallel(self, pattern):
action = parallel_action.ParallelAction()
for p in pattern:
action.add(self.translate(p))
return action
class MultiThreadedActionEngine(ActionEngine):
translator_cls = MultiThreadedTranslator
def __init__(self, flow, flow_detail=None, thread_pool=None):
ActionEngine.__init__(self, flow,
storage=t_storage.ThreadSafeStorage(flow_detail))
if thread_pool:
self._thread_pool = thread_pool
self._owns_thread_pool = False
else:
self._thread_pool = None
self._owns_thread_pool = True
@decorators.locked
def compile(self):
ActionEngine.compile(self)
if self._thread_pool is None:
self._thread_pool = pool.ThreadPool()
@decorators.locked
def run(self):
try:
ActionEngine.run(self)
finally:
# Ensure we close then join on the thread pool to make sure its
# resources get cleaned up correctly.
if self._owns_thread_pool:
self._thread_pool.close()
self._thread_pool.join()
self._thread_pool = None
@property
def thread_pool(self):
return self._thread_pool