When a retry atom or a task atom changes state it is quite useful to know the prior state the atom was in; to make this easier pass that information along in the details about the state transition so that observers can inspect it if they desire to. This matches more closely with the flow notification which does include the prior state (under the details key 'old_state') so this also increases the uniformity of notifications in general. Change-Id: I7df1fcc60ba178198776ddaa2681caee5811c4ff
149 lines
6.0 KiB
Python
149 lines
6.0 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright (C) 2012-2013 Yahoo! Inc. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import functools
|
|
|
|
from taskflow import logging
|
|
from taskflow import states
|
|
from taskflow import task as task_atom
|
|
from taskflow.types import failure
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
SAVE_RESULT_STATES = (states.SUCCESS, states.FAILURE)
|
|
|
|
|
|
class TaskAction(object):
|
|
"""An action that handles scheduling, state changes, ... of task atoms."""
|
|
|
|
def __init__(self, storage, task_executor, notifier, walker_factory):
|
|
self._storage = storage
|
|
self._task_executor = task_executor
|
|
self._notifier = notifier
|
|
self._walker_factory = walker_factory
|
|
|
|
@staticmethod
|
|
def handles(atom):
|
|
return isinstance(atom, task_atom.BaseTask)
|
|
|
|
def _is_identity_transition(self, old_state, state, task, progress):
|
|
if state in SAVE_RESULT_STATES:
|
|
# saving result is never identity transition
|
|
return False
|
|
if state != old_state:
|
|
# changing state is not identity transition by definition
|
|
return False
|
|
# NOTE(imelnikov): last thing to check is that the progress has
|
|
# changed, which means progress is not None and is different from
|
|
# what is stored in the database.
|
|
if progress is None:
|
|
return False
|
|
old_progress = self._storage.get_task_progress(task.name)
|
|
if old_progress != progress:
|
|
return False
|
|
return True
|
|
|
|
def change_state(self, task, state, result=None, progress=None):
|
|
old_state = self._storage.get_atom_state(task.name)
|
|
if self._is_identity_transition(old_state, state, task, progress):
|
|
# NOTE(imelnikov): ignore identity transitions in order
|
|
# to avoid extra write to storage backend and, what's
|
|
# more important, extra notifications
|
|
return
|
|
if state in SAVE_RESULT_STATES:
|
|
self._storage.save(task.name, result, state)
|
|
else:
|
|
self._storage.set_atom_state(task.name, state)
|
|
if progress is not None:
|
|
self._storage.set_task_progress(task.name, progress)
|
|
task_uuid = self._storage.get_atom_uuid(task.name)
|
|
details = {
|
|
'task_name': task.name,
|
|
'task_uuid': task_uuid,
|
|
'result': result,
|
|
'old_state': old_state,
|
|
}
|
|
self._notifier.notify(state, details)
|
|
if progress is not None:
|
|
task.update_progress(progress)
|
|
|
|
def _on_update_progress(self, task, event_type, details):
|
|
"""Should be called when task updates its progress."""
|
|
try:
|
|
progress = details.pop('progress')
|
|
except KeyError:
|
|
pass
|
|
else:
|
|
try:
|
|
self._storage.set_task_progress(task.name, progress,
|
|
details=details)
|
|
except Exception:
|
|
# Update progress callbacks should never fail, so capture and
|
|
# log the emitted exception instead of raising it.
|
|
LOG.exception("Failed setting task progress for %s to %0.3f",
|
|
task, progress)
|
|
|
|
def schedule_execution(self, task):
|
|
self.change_state(task, states.RUNNING, progress=0.0)
|
|
scope_walker = self._walker_factory(task)
|
|
arguments = self._storage.fetch_mapped_args(task.rebind,
|
|
atom_name=task.name,
|
|
scope_walker=scope_walker)
|
|
if task.notifier.can_be_registered(task_atom.EVENT_UPDATE_PROGRESS):
|
|
progress_callback = functools.partial(self._on_update_progress,
|
|
task)
|
|
else:
|
|
progress_callback = None
|
|
task_uuid = self._storage.get_atom_uuid(task.name)
|
|
return self._task_executor.execute_task(
|
|
task, task_uuid, arguments,
|
|
progress_callback=progress_callback)
|
|
|
|
def complete_execution(self, task, result):
|
|
if isinstance(result, failure.Failure):
|
|
self.change_state(task, states.FAILURE, result=result)
|
|
else:
|
|
self.change_state(task, states.SUCCESS,
|
|
result=result, progress=1.0)
|
|
|
|
def schedule_reversion(self, task):
|
|
self.change_state(task, states.REVERTING, progress=0.0)
|
|
scope_walker = self._walker_factory(task)
|
|
arguments = self._storage.fetch_mapped_args(task.rebind,
|
|
atom_name=task.name,
|
|
scope_walker=scope_walker)
|
|
task_uuid = self._storage.get_atom_uuid(task.name)
|
|
task_result = self._storage.get(task.name)
|
|
failures = self._storage.get_failures()
|
|
if task.notifier.can_be_registered(task_atom.EVENT_UPDATE_PROGRESS):
|
|
progress_callback = functools.partial(self._on_update_progress,
|
|
task)
|
|
else:
|
|
progress_callback = None
|
|
future = self._task_executor.revert_task(
|
|
task, task_uuid, arguments, task_result, failures,
|
|
progress_callback=progress_callback)
|
|
return future
|
|
|
|
def complete_reversion(self, task, rev_result):
|
|
if isinstance(rev_result, failure.Failure):
|
|
self.change_state(task, states.FAILURE)
|
|
else:
|
|
self.change_state(task, states.REVERTED, progress=1.0)
|
|
|
|
def wait_for_any(self, fs, timeout):
|
|
return self._task_executor.wait_for_any(fs, timeout)
|