From 4ed9ef91e0b858a9069d19980b5a1ef56a13960a Mon Sep 17 00:00:00 2001
From: Zhiqiang Fan <aji.zqfan@gmail.com>
Date: Sun, 27 Sep 2015 11:13:54 -0600
Subject: [PATCH] remove unnecessary message when running unit test

When we test log related code, we still print the tested log message
into stderr, which is not quite useful for developers, we should
mock those message. Package fixtures.FakeLogger already provides an
option to mock specified logger, so let's use it.

Note: this patch also changes an unnecessary object attribute to local
varible.

Change-Id: I4bc5beaa4eba149f12c58f072fe66163aed8c0c8
Closes-Bug: #1500236
---
 troveclient/tests/test_client.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/troveclient/tests/test_client.py b/troveclient/tests/test_client.py
index f901c13..eac6439 100644
--- a/troveclient/tests/test_client.py
+++ b/troveclient/tests/test_client.py
@@ -186,8 +186,9 @@ class ClientTest(testtools.TestCase):
                                 'http://foo.com/trove/')
 
     def test_log_req(self):
-        self.logger = self.useFixture(
+        logger = self.useFixture(
             fixtures.FakeLogger(
+                name='troveclient.client',
                 format="%(message)s",
                 level=logging.DEBUG,
                 nuke_handlers=True
@@ -207,7 +208,7 @@ class ClientTest(testtools.TestCase):
              'data': '{"auth": {"passwordCredentials": '
              '{"password": "password"}}}'})
 
-        output = self.logger.output.split('\n')
+        output = logger.output.split('\n')
 
         self.assertIn("REQ: curl -i /foo -X GET", output)
         self.assertIn(