openstack
/
deb-python-yaql
Code Issues Proposed changes

Update notes for submitted changes 

* Use __slots__ for yaqltypes
* Use __slots__ for Parameter/Function definition
* Don't include openstack/common in flake8 exclude list
* Drop MANIFEST.in - it's not needed by pbr
This commit is contained in:
Gerrit Code Review 2016-12-01 07:58:03 +00:00
parent 0636c9da16
commit 3ef21273a8
4 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
16cd8ade86f3d1e546be38f78c4a11d4d59a55fd Normal file
View File

@ -0,0 +1,10 @@
Code-Review+1: Kirill Zaitsev <k.zaitsev@me.com>
Code-Review+1: Felipe Monteiro <felipe.monteiro@att.com>
Code-Review+2: Serg Melikyan <smelikyan@mirantis.com>
Workflow+1: Serg Melikyan <smelikyan@mirantis.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Wed, 30 Nov 2016 22:40:14 +0000
Reviewed-on: https://review.openstack.org/389812
Project: openstack/deb-python-yaql
Branch: refs/heads/master

12
42fed1a86d92afc47825a5ddb180a631ce927dfe Normal file
View File

@ -0,0 +1,12 @@
Code-Review+1: Thomas Herve <therve@redhat.com>
Code-Review+1: Kirill Zaitsev <k.zaitsev@me.com>
Code-Review+1: DavidPurcell <david.purcell@att.com>
Code-Review+2: Stan Lagun <slagun@mirantis.com>
Code-Review+2: Serg Melikyan <smelikyan@mirantis.com>
Workflow+1: Serg Melikyan <smelikyan@mirantis.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Thu, 01 Dec 2016 01:21:25 +0000
Reviewed-on: https://review.openstack.org/393473
Project: openstack/deb-python-yaql
Branch: refs/heads/master

9
994b7bcb680f779981f4005242792034e9d8fad8 Normal file
View File

@ -0,0 +1,9 @@
Code-Review+1: Kirill Zaitsev <k.zaitsev@me.com>
Code-Review+2: Serg Melikyan <smelikyan@mirantis.com>
Workflow+1: Serg Melikyan <smelikyan@mirantis.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Wed, 30 Nov 2016 22:40:21 +0000
Reviewed-on: https://review.openstack.org/389254
Project: openstack/deb-python-yaql
Branch: refs/heads/master

11
e693e6ecef9c331d4567c6708803e0d9cff1c15a Normal file
View File

@ -0,0 +1,11 @@
Code-Review+1: Thomas Herve <therve@redhat.com>
Code-Review+1: Kirill Zaitsev <k.zaitsev@me.com>
Code-Review+2: Stan Lagun <slagun@mirantis.com>
Code-Review+2: Serg Melikyan <smelikyan@mirantis.com>
Workflow+1: Serg Melikyan <smelikyan@mirantis.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Thu, 01 Dec 2016 01:22:19 +0000
Reviewed-on: https://review.openstack.org/393474
Project: openstack/deb-python-yaql
Branch: refs/heads/master