openstack/deb-ryu
Code Issues Proposed changes

service/ovsdb: Avoid to use dict as default argument

Browse Source 
Using mutable values as default arguments will cause unexpected behavior.

Signed-off-by: Satoshi Fujimoto <satoshi.fujimoto7@gmail.com>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
This commit is contained in:
Satoshi Fujimoto 2017-06-16 11:45:44 +09:00 committed by FUJITA Tomonori
parent cf667e4097
commit 27b8d44bb1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ryu/services/protocols/ovsdb/client.py
View File

@ -286,7 +286,8 @@ class RemoteOvsdb(app_manager.RyuApp):
@classmethod
def factory(cls, sock, address, probe_interval=None, min_backoff=None,
max_backoff=None, schema_tables=None,
schema_exclude_columns={}, *args, **kwargs):
schema_exclude_columns=None, *args, **kwargs):
schema_exclude_columns = schema_exclude_columns or {}
ovs_stream = stream.Stream(sock, None, None)
connection = jsonrpc.Connection(ovs_stream)
schemas = discover_schemas(connection)