openstack/deb-ryu
Code Issues Proposed changes

lib/packet/lldp.py: pylint

Browse Source 
> W: 78,0:LLDPBasicTLV.__init__: Unused argument 'args'
> W: 78,0:LLDPBasicTLV.__init__: Unused argument 'kwargs'
> W:109,4:lldp.__init__: __init__ method from base class 'PacketBase' is not called

Cc: "can." <can@canx.me>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
This commit is contained in:
Isaku Yamahata 2013-04-09 11:01:17 +09:00 committed by FUJITA Tomonori
parent 521fbcf000
commit 3a4bdd3296
1 changed files with 3 additions and 1 deletions

4
ryu/lib/packet/lldp.py

@ -75,7 +75,8 @@ class LLDPBasicTLV(object):
_LEN_MAX = 511 _LEN_MAX = 511
tlv_type = None tlv_type = None
def __init__(self, buf=None, *args, **kwargs): def __init__(self, buf=None, *_args, **_kwargs):
super(LLDPBasicTLV, self).__init__()
if buf: if buf:
(self.typelen, ) = struct.unpack( (self.typelen, ) = struct.unpack(
LLDP_TLV_TYPELEN_STR, buf[:LLDP_TLV_SIZE]) LLDP_TLV_TYPELEN_STR, buf[:LLDP_TLV_SIZE])
@ -108,6 +109,7 @@ class lldp(packet_base.PacketBase):
tlvs = [] tlvs = []
def __init__(self, tlvs): def __init__(self, tlvs):
super(lldp, self).__init__()
self.tlvs = tlvs self.tlvs = tlvs
length = 0 length = 0
for tlv in tlvs: for tlv in tlvs: