openstack/deb-ryu
Code Issues Proposed changes

ofproto/ofproto_v1_0_parser: improve NXTRequest initializer

Browse Source 
initialize subtype by base class, NXTRequest, instead of subclass.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Reviewed-by: Simon Horman <simon@horms.net>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
This commit is contained in:
Isaku Yamahata 2012-04-04 18:37:50 +09:00 committed by FUJITA Tomonori
parent 72bb1a1e85
commit c88e1845c8
1 changed files with 5 additions and 5 deletions

10
ryu/ofproto/ofproto_v1_0_parser.py

@ -692,9 +692,10 @@ class OFPVendor(MsgBase):
class NXTRequest(OFPVendor):
def __init__(self, datapath):
def __init__(self, datapath, subtype):
super(NXTRequest, self).__init__(datapath)
self.vendor = ofproto_v1_0.NX_VENDOR_ID
self.subtype = subtype
def serialize_header(self):
super(NXTRequest, self).serialize_header()
@ -705,8 +706,8 @@ class NXTRequest(OFPVendor):
class NXTSetFlowFormat(NXTRequest):
def __init__(self, datapath, format):
super(NXTSetFlowFormat, self).__init__(datapath)
self.subtype = ofproto_v1_0.NXT_SET_FLOW_FORMAT
super(NXTSetFlowFormat, self).__init__(
datapath, ofproto_v1_0.NXT_SET_FLOW_FORMAT)
self.format = format
def _serialize_body(self):
@ -719,8 +720,7 @@ class NXTFlowMod(NXTRequest):
def __init__(self, datapath, cookie, command, idle_timeout,
hard_timeout, priority, buffer_id, out_port,
flags, rule, actions):
super(NXTFlowMod, self).__init__(datapath)
self.subtype = ofproto_v1_0.NXT_FLOW_MOD
super(NXTFlowMod, self).__init__(datapath, ofproto_v1_0.NXT_FLOW_MOD)
self.cookie = cookie
self.command = command
self.idle_timeout = idle_timeout