openstack/deb-sahara
Code Issues Proposed changes

Use assertTrue/False instead of assertEqual(T/F)

Browse Source 
The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: I4e1918426e39a70c8b971d171d774ad5e241f2ae
Closes-Bug: #1512207
This commit is contained in:
yangyapeng 2015-10-28 18:25:36 -04:00
parent ef2dbb0e83
commit 63a67d16a3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sahara/tests/unit/conductor/test_api.py
View File

@ -211,7 +211,7 @@ class TestConductorApi(base.SaharaWithDbTestCase):
events = self._get_events(ctx, cluster.id, step_id) events = self._get_events(ctx, cluster.id, step_id)
self.assertEqual(1, len(events)) self.assertEqual(1, len(events))
self.assertEqual(st_name, events[0].instance_name) self.assertEqual(st_name, events[0].instance_name)
self.assertEqual(True, events[0].successful) self.assertTrue(events[0].successful)
self.assertEqual(st_info, events[0].event_info) self.assertEqual(st_info, events[0].event_info)
self.api.cluster_destroy(ctx, cluster.id) self.api.cluster_destroy(ctx, cluster.id)

4
sahara/tests/unit/utils/test_cluster_progress_ops.py
View File

@ -78,7 +78,7 @@ class ClusterProgressOpsTest(base.SaharaWithDbTestCase):
result_cluster = self.api.cluster_get(ctx, cluster.id) result_cluster = self.api.cluster_get(ctx, cluster.id)
result_step = result_cluster.provision_progress[0] result_step = result_cluster.provision_progress[0]
self.assertEqual(True, result_step.successful) self.assertTrue(result_step.successful)
# check updating in case of failed provision step # check updating in case of failed provision step
@ -98,7 +98,7 @@ class ClusterProgressOpsTest(base.SaharaWithDbTestCase):
for step in result_cluster.provision_progress: for step in result_cluster.provision_progress:
if step.id == step_id2: if step.id == step_id2:
self.assertEqual(False, step.successful) self.assertFalse(step.successful)
# check that it's possible to add provision step after failed step # check that it's possible to add provision step after failed step
step_id3 = cpo.add_provisioning_step(cluster.id, "some_name", 2) step_id3 = cpo.add_provisioning_step(cluster.id, "some_name", 2)