openstack/deb-sahara
Code Issues Proposed changes

Replace deprecated library function os.popen() with subprocess

Browse Source 
os.popen() is deprecated since version 2.6. Resolved with use of
subprocess module.
Closes-bug: #1529836

Change-Id: Iabc3e551335640928b40f9d9751ddfb72a77584c
This commit is contained in:
LiuNanke 2016-01-09 21:49:53 +08:00
parent 3cbfb4d0d1
commit 9e4b7c735b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/source/conf.py
View File

@ -15,9 +15,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
import sys
import os
import subprocess
import sys
on_rtd = os.environ.get('READTHEDOCS', None) == 'True'
@ -148,8 +148,10 @@ html_static_path = ['_static']
# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.
#html_last_updated_fmt = '%b %d, %Y'
git_cmd = "git log --pretty=format:'%ad, commit %h' --date=local -n1"
html_last_updated_fmt = os.popen(git_cmd).read()
git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local",
"-n1"]
html_last_updated_fmt = subprocess.Popen(git_cmd,
stdout=subprocess.PIPE).communicate()[0]
# If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities.