openstack/deb-sahara
Code Issues Proposed changes

Removed error log for failure inside individual thread

Browse Source 
We don't want to have all errors from all threads logged on
ERROR level. E.g. in case of network failure and 10 parallel VM
tasks there will be 10 stacktraces in the logs. Parent thread
will receive the first exception and in most cases it is enough
to treat operation over all threads as errored.

Change-Id: Idc93c33f41d502e5aa0149b93ce816379c1043b1
Closes-Bug: #1421032
This commit is contained in:
Andrew Lazarev 2015-02-13 10:35:19 -08:00
parent 39276bd606
commit d8c602cdf0
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sahara/context.py
View File

@ -24,7 +24,6 @@ from oslo_log import log as logging
from sahara import exceptions as ex from sahara import exceptions as ex
from sahara.i18n import _ from sahara.i18n import _
from sahara.i18n import _LE
from sahara.i18n import _LW from sahara.i18n import _LW
@ -189,8 +188,8 @@ def _wrapper(ctx, thread_description, thread_group, func, *args, **kwargs):
set_ctx(ctx) set_ctx(ctx)
func(*args, **kwargs) func(*args, **kwargs)
except BaseException as e: except BaseException as e:
LOG.exception( LOG.debug(
_LE("Thread '%(thread)s' fails with exception: '%(exception)s'"), "Thread '%(thread)s' failed with exception: '%(exception)s'",
{'thread': thread_description, 'exception': e}) {'thread': thread_description, 'exception': e})
if thread_group and not thread_group.exc: if thread_group and not thread_group.exc:
thread_group.exc = e thread_group.exc = e