openstack/deb-senlin
Code Issues Proposed changes

Optimize the registry claim function

Browse Source 
The previous implementation was buggy. It was returning all registry
entries no matter they belong to dead engines or not. This patch
optimizes the implementation also revised the test cases.

Change-Id: I1f338fe99171de65600c567003afe4d2cc71122c
This commit is contained in:
tengqm
2016-02-29 08:32:15 -05:00
parent 0fe46da23e
commit 10e9600824
2 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
senlin/tests/unit/db/test_registry_api.py
View File

@@ -21,6 +21,8 @@ class DBAPIRegistryTest(base.SenlinTestCase):
super(DBAPIRegistryTest, self).setUp()
self.ctx = utils.dummy_context()
db_api.service_create(self.ctx, 'SERVICE_ID')
def _create_registry(self, cluster_id, check_type, interval, params,
engine_id):
return db_api.registry_create(self.ctx, cluster_id, check_type,
@@ -36,8 +38,7 @@ class DBAPIRegistryTest(base.SenlinTestCase):
self.assertEqual(1, len(ret_registries))
ret_registry = ret_registries[0]
self.assertEqual(registry.id, ret_registry.id)
self.assertEqual(registry.cluster_id,
ret_registry.cluster_id)
self.assertEqual(registry.cluster_id, ret_registry.cluster_id)
self.assertEqual(registry.check_type, ret_registry.check_type)
self.assertEqual(registry.interval, ret_registry.interval)
self.assertEqual(registry.params, ret_registry.params)