openstack/deb-swift
Code Issues Proposed changes

Input validation must not depend on the locale

Browse Source 
storage_policy.py: replace string.letters with string.ascii_letters.

This change does not change the behaviour on Python 2. It is only needed
for Python 3 because string.letters was removed.

On Python 2, string.letters is modified when locale.setlocale() is
called. Hopefully, Swift doesn't call setlocale() and so it's safe to
replace it.

Change-Id: Ifbf9332ae739b1bfc9e6d2831f4e7581e69f233d
This commit is contained in:
Victor Stinner 2015-08-27 00:56:08 +02:00
parent f0af259aae
commit 4feaccf014
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
swift/common/storage_policy.py
View File

@ -27,7 +27,7 @@ from swift.common.exceptions import RingValidationError
from pyeclib.ec_iface import ECDriver, ECDriverError, VALID_EC_TYPES
LEGACY_POLICY_NAME = 'Policy-0'
VALID_CHARS = '-' + string.letters + string.digits
VALID_CHARS = '-' + string.ascii_letters + string.digits
DEFAULT_POLICY_TYPE = REPL_POLICY = 'replication'
EC_POLICY = 'erasure_coding'