b610b77df4
Currently compute security_groups_client returns Response by removing top key from Response. For example- return service_client.ResponseBody(resp, body['security_group']) As service clients are in direction to move to Tempest-lib, all service clients should return Response without any truncation. One good example is Resource pagination links which are lost with current way of return value. Resource pagination links are present in parallel (not inside) to top key of Response. This patch makes compute security_groups_client to return complete Response body. Change-Id: I8cfd1845be221ae2e3629cc79ab5fdfd14ac48d4 Implements: blueprint method-return-value-and-move-service-clients-to-lib
87 lines
3.7 KiB
Python
87 lines
3.7 KiB
Python
# Copyright 2013 NTT Data
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import testtools
|
|
|
|
from tempest.api.compute import base
|
|
from tempest.common.utils import data_utils
|
|
from tempest import config
|
|
from tempest import test
|
|
|
|
CONF = config.CONF
|
|
|
|
|
|
class SecurityGroupsTestAdminJSON(base.BaseV2ComputeAdminTest):
|
|
|
|
@classmethod
|
|
def setup_clients(cls):
|
|
super(SecurityGroupsTestAdminJSON, cls).setup_clients()
|
|
cls.adm_client = cls.os_adm.security_groups_client
|
|
cls.client = cls.security_groups_client
|
|
|
|
def _delete_security_group(self, securitygroup_id, admin=True):
|
|
if admin:
|
|
self.adm_client.delete_security_group(securitygroup_id)
|
|
else:
|
|
self.client.delete_security_group(securitygroup_id)
|
|
|
|
@test.idempotent_id('49667619-5af9-4c63-ab5d-2cfdd1c8f7f1')
|
|
@testtools.skipIf(CONF.service_available.neutron,
|
|
"Skipped because neutron does not support all_tenants "
|
|
"search filter.")
|
|
@test.services('network')
|
|
def test_list_security_groups_list_all_tenants_filter(self):
|
|
# Admin can list security groups of all tenants
|
|
# List of all security groups created
|
|
security_group_list = []
|
|
# Create two security groups for a non-admin tenant
|
|
for i in range(2):
|
|
name = data_utils.rand_name('securitygroup')
|
|
description = data_utils.rand_name('description')
|
|
securitygroup = self.client.create_security_group(
|
|
name=name, description=description)['security_group']
|
|
self.addCleanup(self._delete_security_group,
|
|
securitygroup['id'], admin=False)
|
|
security_group_list.append(securitygroup)
|
|
|
|
client_tenant_id = securitygroup['tenant_id']
|
|
# Create two security groups for admin tenant
|
|
for i in range(2):
|
|
name = data_utils.rand_name('securitygroup')
|
|
description = data_utils.rand_name('description')
|
|
adm_securitygroup = self.adm_client.create_security_group(
|
|
name=name, description=description)['security_group']
|
|
self.addCleanup(self._delete_security_group,
|
|
adm_securitygroup['id'])
|
|
security_group_list.append(adm_securitygroup)
|
|
|
|
# Fetch all security groups based on 'all_tenants' search filter
|
|
fetched_list = self.adm_client.list_security_groups(
|
|
all_tenants='true')['security_groups']
|
|
sec_group_id_list = map(lambda sg: sg['id'], fetched_list)
|
|
# Now check if all created Security Groups are present in fetched list
|
|
for sec_group in security_group_list:
|
|
self.assertIn(sec_group['id'], sec_group_id_list)
|
|
|
|
# Fetch all security groups for non-admin user with 'all_tenants'
|
|
# search filter
|
|
fetched_list = (self.client.list_security_groups(all_tenants='true')
|
|
['security_groups'])
|
|
# Now check if all created Security Groups are present in fetched list
|
|
for sec_group in fetched_list:
|
|
self.assertEqual(sec_group['tenant_id'], client_tenant_id,
|
|
"Failed to get all security groups for "
|
|
"non admin user.")
|