openstack/deb-zaqar
Code Issues Proposed changes

Fix cleanup in metadata putting test

Browse Source 
Now, if you will try to run two times this command:
tox -e py27 wsgi.v2_0.test_validation.TestValidation.test_queue_metadata
_putting
You will see: MismatchError: '201 Created' != '204 No Content'

This is because cleanUp() is not written good in this test case.
self.simulate_delete function has missing argument: project id, so the
default project id is used instead during cleanUp().

The problem went unnoticed, because we usually run all tests. And when
all tests run the database is somehow cleaned in the place we need to
clean.

Change-Id: Id0241aeb76aabcb5e57098b0f02d26e62aead42e
This commit is contained in:
Eva Balycheva 2016-03-15 06:44:55 +03:00
parent 114c9dee6b
commit f3a4132684
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
zaqar/tests/unit/transport/wsgi/v2_0/test_validation.py
View File

@ -121,7 +121,8 @@ class TestValidation(base.V2Base):
self.simulate_put(queue_1, self.simulate_put(queue_1,
self.project_id, self.project_id,
body='{"_default_message_ttl": 60}') body='{"_default_message_ttl": 60}')
self.addCleanup(self.simulate_delete, queue_1, headers=self.headers) self.addCleanup(self.simulate_delete, queue_1, self.project_id,
headers=self.headers)
self.assertEqual(falcon.HTTP_201, self.srmock.status) self.assertEqual(falcon.HTTP_201, self.srmock.status)
# TTL under min # TTL under min
@ -142,7 +143,8 @@ class TestValidation(base.V2Base):
self.simulate_put(queue_2, self.simulate_put(queue_2,
self.project_id, self.project_id,
body='{"_max_messages_post_size": 255}') body='{"_max_messages_post_size": 255}')
self.addCleanup(self.simulate_delete, queue_2, headers=self.headers) self.addCleanup(self.simulate_delete, queue_2, self.project_id,
headers=self.headers)
self.assertEqual(falcon.HTTP_201, self.srmock.status) self.assertEqual(falcon.HTTP_201, self.srmock.status)
# Size over max # Size over max