openstack/designate-dashboard
Code Issues Proposed changes

Remove "-y" option for package install command.

Browse Source 
According to "code conventions" [1], do not use "-y" option.
Instead, use apt-get install package, yum install package, or zypper install package.

[1] https://docs.openstack.org/doc-contrib-guide/writing-style/code-conventions

Change-Id: I97549b78b95cce9ba660b5b8e360d2ee5e6bc2a6
This commit is contained in:
luke.li 2018-05-09 09:45:52 +08:00
parent 5055fd3d25
commit 631f96cb05
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.rst
View File

@ -71,7 +71,7 @@ Test
$ ``sudo apt-get install npm``
$ ``curl -sL https://deb.nodesource.com/setup_4.x | sudo -E bash -``
$ ``sudo apt-get install -y nodejs``
$ ``sudo apt-get install nodejs``
1. ``npm install`` (to create virtual environment and install all dependencies in package.json)
2. ``npm run lint`` for eslint