From 64e2e58b4e52f9bfdb74d30b094e8b048d2a1c7e Mon Sep 17 00:00:00 2001 From: manchandavishal Date: Mon, 14 Dec 2020 09:06:21 +0000 Subject: [PATCH] Run npm nodejs job with Firefox browser This patch update browser from Chrome to Firefox in karma.conf.js becuase nodejs fails with Chrome browser as not able to access some URL. So let's switch to Firefox browser now then we can use Chrome browser in future once this issue is resolved. Change-Id: Id5186f16656e0671dda7ab91062c104b2c08758f Signed-off-by: Nicolas Bock --- .zuul.yaml | 2 +- karma.conf.js | 4 ++-- package.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.zuul.yaml b/.zuul.yaml index c860d03..aeb07d6 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -2,7 +2,7 @@ templates: - check-requirements - horizon-non-primary-django-jobs - # - horizon-nodejs10-jobs + - horizon-nodejs10-jobs - openstack-cover-jobs-horizon # - openstack-lower-constraints-jobs - openstack-python3-wallaby-jobs-horizon diff --git a/karma.conf.js b/karma.conf.js index a177ce3..559aa35 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -121,7 +121,7 @@ module.exports = function (config) { frameworks: ['jasmine'], - browsers: ['Chrome'], + browsers: ['Firefox'], phantomjsLauncher: { // Have phantomjs exit if a ResourceError is encountered @@ -132,7 +132,7 @@ module.exports = function (config) { reporters: ['progress'], plugins: [ - 'karma-chrome-launcher', + 'karma-firefox-launcher', 'karma-jasmine', 'karma-ng-html2js-preprocessor' ] diff --git a/package.json b/package.json index dc265b4..577863f 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "eslint-config-openstack": "1.2.4", "jasmine-core": "2.4.1", "karma": "~1.1.2", - "karma-chrome-launcher": "1.0.1", + "karma-firefox-launcher": "2.1.0", "karma-cli": "1.0.1", "karma-jasmine": "1.0.2", "karma-ng-html2js-preprocessor": "1.0.0"