diff --git a/4f4be0269b7d48c666c08a35f975d99b6f0a1596 b/4f4be0269b7d48c666c08a35f975d99b6f0a1596 index 4641934b..ca93c423 100644 --- a/4f4be0269b7d48c666c08a35f975d99b6f0a1596 +++ b/4f4be0269b7d48c666c08a35f975d99b6f0a1596 @@ -23,6 +23,29 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "5a18252c_1a19d9d7", + "filename": "designate_tempest_plugin/services/dns/v2/json/zones_import_client.py", + "patchSetId": 7 + }, + "lineNbr": 37, + "author": { + "id": 8556 + }, + "writtenOn": "2016-04-14T06:38:07Z", + "side": 1, + "message": "There is no such method, you need to add in waiters", + "range": { + "startLine": 37, + "startChar": 12, + "endLine": 37, + "endChar": 47 + }, + "revId": "4f4be0269b7d48c666c08a35f975d99b6f0a1596", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "5a18252c_9f7b1b28", @@ -45,6 +68,29 @@ "revId": "4f4be0269b7d48c666c08a35f975d99b6f0a1596", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false + }, + { + "key": { + "uuid": "5a18252c_5aa2314c", + "filename": "designate_tempest_plugin/tests/api/v2/test_zones_imports.py", + "patchSetId": 7 + }, + "lineNbr": 31, + "author": { + "id": 8556 + }, + "writtenOn": "2016-04-14T06:38:07Z", + "side": 1, + "message": "Similar function in https://github.com/openstack/designate-tempest-plugin/blob/master/designate_tempest_plugin/tests/api/v2/test_zones.py#L26\n\nMove this to base class and use in all tests wherever needed.\n\nhere base.BaseDnsTest\n\n def _assertExpected_import(self, expected, actual):\n for key, value in six.iteritems(expected):\n if key not in self.excluded_keys:\n self.assertIn(key, actual)\n self.assertEqual(value, actual[key], key)\n\nthen-\n\nclass ZonesImportTest(BaseZonesImportTest):\n excluded_keys \u003d (\u0027created_at\u0027, \u0027updated_at\u0027, \u0027version\u0027, \u0027links\u0027, \u0027status\u0027, \u0027message\u0027)\n\nAfter that you do not need BaseZonesImportTest.\n\nBut do it in separate patch for more clear review.", + "range": { + "startLine": 26, + "startChar": 0, + "endLine": 31, + "endChar": 57 + }, + "revId": "4f4be0269b7d48c666c08a35f975d99b6f0a1596", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false } ] } \ No newline at end of file