From 4bffdd3484e88e6331c8ebab6a080d837f2696a4 Mon Sep 17 00:00:00 2001 From: Gerrit User 11628 <11628@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 21 Jul 2023 22:19:55 +0000 Subject: [PATCH] Update patch set 3 Patch Set 3: Code-Review-1 (4 comments) Patch-set: 3 Reviewer: Gerrit User 11628 <11628@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 9a75b46d711ef170f8cbf0902918d928605376d2 Attention: {"person_ident":"Gerrit User 11628 \u003c11628@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11628\u003e replied on the change"} --- 1276b5f71feec5aa3f09fb7dc2d3f4fe5641839c | 72 ++++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 1276b5f71feec5aa3f09fb7dc2d3f4fe5641839c diff --git a/1276b5f71feec5aa3f09fb7dc2d3f4fe5641839c b/1276b5f71feec5aa3f09fb7dc2d3f4fe5641839c new file mode 100644 index 00000000..591d15dd --- /dev/null +++ b/1276b5f71feec5aa3f09fb7dc2d3f4fe5641839c @@ -0,0 +1,72 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "f17b9a7d_47a46681", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 3 + }, + "lineNbr": 0, + "author": { + "id": 11628 + }, + "writtenOn": "2023-07-21T22:19:55Z", + "side": 1, + "message": "Thank you for doing this!\nI only had one set of comments that we should keep the old test ID for the first test in the unrolled group so that refstack doesn\u0027t through a missing test error.", + "revId": "1276b5f71feec5aa3f09fb7dc2d3f4fe5641839c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "5b7ea4ac_d3932a0e", + "filename": "designate_tempest_plugin/tests/api/v2/test_recordset.py", + "patchSetId": 3 + }, + "lineNbr": 214, + "author": { + "id": 11628 + }, + "writtenOn": "2023-07-21T22:19:55Z", + "side": 1, + "message": "We should keep the old test ID as the ID on the first test case:\n69f002e5-6511-43d3-abae-7abdd45ae03e\n\nOtherwise refstack may throw an error.", + "revId": "1276b5f71feec5aa3f09fb7dc2d3f4fe5641839c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "a28bd0c9_23ab0f41", + "filename": "designate_tempest_plugin/tests/api/v2/test_recordset.py", + "patchSetId": 3 + }, + "lineNbr": 648, + "author": { + "id": 11628 + }, + "writtenOn": "2023-07-21T22:19:55Z", + "side": 1, + "message": "Same here, let\u0027s keep the old ID on the first test case:\n98c94f8c-217a-4056-b996-b1f856d0753e", + "revId": "1276b5f71feec5aa3f09fb7dc2d3f4fe5641839c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "1da19ca1_b8004a11", + "filename": "designate_tempest_plugin/tests/scenario/v2/test_recordsets.py", + "patchSetId": 3 + }, + "lineNbr": 124, + "author": { + "id": 11628 + }, + "writtenOn": "2023-07-21T22:19:55Z", + "side": 1, + "message": "Same here, let\u0027s keep the old id on this one:\n4664ed66-9ff1-45f2-9e60-d4913195c505", + "revId": "1276b5f71feec5aa3f09fb7dc2d3f4fe5641839c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file