From 7eb8a8d33838cdbde9107b7948826da73f4a18ed Mon Sep 17 00:00:00 2001 From: Gerrit User 11628 <11628@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 12 Apr 2023 22:59:37 +0000 Subject: [PATCH] Update patch set 15 Patch Set 15: Code-Review-1 (46 comments) Patch-set: 15 Reviewer: Gerrit User 11628 <11628@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 3d5b0a9af8bc921fb1a58444f751f6628a5b3269 --- 5d6aaea210832b5d67a4495a4c5a1ff5d498e031 | 806 +++++++++++++++++++++++ 1 file changed, 806 insertions(+) diff --git a/5d6aaea210832b5d67a4495a4c5a1ff5d498e031 b/5d6aaea210832b5d67a4495a4c5a1ff5d498e031 index f0f2d4f9..fddcb3c7 100644 --- a/5d6aaea210832b5d67a4495a4c5a1ff5d498e031 +++ b/5d6aaea210832b5d67a4495a4c5a1ff5d498e031 @@ -50,6 +50,812 @@ "message": "recheck\ngrenade gate issue is resolved", "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "b08a8468_8d826b50", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 15 + }, + "lineNbr": 0, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We have a few things to fix here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "2f35838c_04d84051", + "filename": "designate_tempest_plugin/data_utils.py", + "patchSetId": 15 + }, + "lineNbr": 22, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "This should be up under the \"from string\" section as uuid is a python builtin.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "0261718a_3acd5a3e", + "filename": "designate_tempest_plugin/data_utils.py", + "patchSetId": 15 + }, + "lineNbr": 298, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Consider using the data_utils from tempest for this:\nhttps://github.com/openstack/tempest/blob/master/tempest/lib/common/utils/data_utils.py#L24", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "96cdf0b7_80856f32", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 288, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "The fix for this bug has merged, we should be able to remove this skip.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "bbb3650b_06b7afb6", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 311, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "\"is True\" is not needed here, you can just use \"config.CONF.dns.nameservers\"", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "22de8713_a0c12a83", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 312, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "This comment doesn\u0027t seem to go with the skip condition.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "bd4c724f_304603ff", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 317, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "The sudo header is different than the all_projects_header.\nhttps://docs.openstack.org/api-ref/dns/dns-api-v2-index.html?expanded\u003dcreate-shared-zone-detail#id52", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "6e50f490_cb510bc5", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 360, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Same two comments as above.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "56d41b30_2b748bce", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 365, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Same here, sudo header is not the all projects header.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "5976b525_c7b9585c", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 403, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Same two comments as above.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "76cbf900_f1ef0585", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 408, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Sudo header is not the same as the all projects header", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "bba85db9_25116491", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 411, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "This header really isn\u0027t needed here right?", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "a3d7e909_c5a2991b", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 414, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "This header really isn\u0027t needed here right?", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "3f90bb9c_8ff365a3", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 453, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "19b599bb_f8b7c279", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 455, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "lambda is not needed here. Use:\n(\u003cexception\u003e, \u003cmethod name\u003e, \u003cparam\u003e, \u003cparam\u003e, etc.)", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "ef07ea66_6272e73b", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 467, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "lambda is not needed here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "87470db2_abd8f355", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 468, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "ae629cff_afb9866d", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 478, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "lambda is not needed here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "902abcb9_c86b9f97", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 479, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "1b9b9d47_bcab724f", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 495, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "366e4715_70dd1ea6", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 497, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "lambda is not needed here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "8980b10f_aad18579", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 509, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "lambda is not needed here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "3bcc586f_1b63b9a2", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 510, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "68755f4a_924ce2c5", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 518, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "de78769d_d3a9c768", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 520, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "lambda is not needed here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "69dc396e_866fc9c7", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 524, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "test_delete_zone_share_invalid_project_id", + "range": { + "startLine": 524, + "startChar": 8, + "endLine": 524, + "endChar": 43 + }, + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "cac9aef9_d4281cc6", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 538, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "21aeac7c_4f6c5a20", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 540, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "lambda is not needed here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "55035cda_8d901da0", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 545, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "test_delete_zone_share_invalide_shared_zone_id", + "range": { + "startLine": 545, + "startChar": 8, + "endLine": 545, + "endChar": 47 + }, + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "57392035_e1c5ec20", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 559, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "lambda is not needed here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "77fe7769_d6e31b51", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 560, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "4d583a06_b0e64939", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 564, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "test_delete_zone_share_invalid_zone_id", + "range": { + "startLine": 564, + "startChar": 8, + "endLine": 564, + "endChar": 41 + }, + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "cb946ff0_92ccf601", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 578, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "lambda is not needed here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "287a1be3_520d3322", + "filename": "designate_tempest_plugin/tests/api/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 579, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "338d8027_7d9fb4f3", + "filename": "designate_tempest_plugin/tests/api/v2/test_zones.py", + "patchSetId": 15 + }, + "lineNbr": 255, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Since you updated the delete_zone client to have a delete_shares parameter, we should update this test to use it.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "9f4a5640_fe10008d", + "filename": "designate_tempest_plugin/tests/api/v2/test_zones.py", + "patchSetId": 15 + }, + "lineNbr": 256, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Since you updated the delete_zone client to have a delete_shares parameter, we should update this test to use it.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "a7d71e04_f358d307", + "filename": "designate_tempest_plugin/tests/api/v2/test_zones.py", + "patchSetId": 15 + }, + "lineNbr": 688, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "f7fa36f0_8318cd54", + "filename": "designate_tempest_plugin/tests/api/v2/test_zones.py", + "patchSetId": 15 + }, + "lineNbr": 700, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "66763df9_ff6ba3fd", + "filename": "designate_tempest_plugin/tests/api/v2/test_zones.py", + "patchSetId": 15 + }, + "lineNbr": 707, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably us data_utils from tempest for this.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "5fae2271_98273468", + "filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py", + "patchSetId": 15 + }, + "lineNbr": 459, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Only a project with admin can set a quota, so this sudo should not be used here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "88a2cae1_f1530f81", + "filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py", + "patchSetId": 15 + }, + "lineNbr": 498, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Only a project with admin can set a quota, so this sudo should not be used here. It will be ignored.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "84c2b1c0_9b0001fb", + "filename": "designate_tempest_plugin/tests/scenario/v2/test_quotas.py", + "patchSetId": 15 + }, + "lineNbr": 539, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "Only a project with admin can set a quota, so this sudo should not be used here. It will be ignored.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "fe0a6d19_6bf1e506", + "filename": "designate_tempest_plugin/tests/scenario/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 217, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "to", + "range": { + "startLine": 217, + "startChar": 34, + "endLine": 217, + "endChar": 37 + }, + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "7605088f_620e7935", + "filename": "designate_tempest_plugin/tests/scenario/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 228, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "We should probably use:\nself.zones_client.project_id here as that is the project the zone was created with. Even though both zones_client and share_zone_client are using the \"primary\" project, it\u0027s confusing to mix the clients here.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "da4fb014_92181bda", + "filename": "designate_tempest_plugin/tests/scenario/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 392, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "This says \"delete\", but the test tries to create a zone export (which is duplicate to the test above).", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "514946a5_7becfb3c", + "filename": "designate_tempest_plugin/tests/scenario/v2/test_shared_zones.py", + "patchSetId": 15 + }, + "lineNbr": 408, + "author": { + "id": 11628 + }, + "writtenOn": "2023-04-12T22:59:37Z", + "side": 1, + "message": "This test never creates a zone export, so the test is invalid.", + "revId": "5d6aaea210832b5d67a4495a4c5a1ff5d498e031", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file