diff --git a/a5ba980ef4840a13032098bc583d556bbdef2b94 b/a5ba980ef4840a13032098bc583d556bbdef2b94 new file mode 100644 index 00000000..5c39cba1 --- /dev/null +++ b/a5ba980ef4840a13032098bc583d556bbdef2b94 @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "7e26d5b8_6ca79004", + "filename": "/PATCHSET_LEVEL", + "patchSetId": 2 + }, + "lineNbr": 0, + "author": { + "id": 28609 + }, + "writtenOn": "2023-04-18T10:43:01Z", + "side": 1, + "message": "Hi Michael!\n \nThe \"test_update_records_propagated_to_backends\" in its current manner is testing the exactly a SAME LOGIC for various record types provided by ddt module, so what is wrong in having a single idempotent ID for all? 😕\n\nIn case of failure we could just improve the Error message logged by adding the type in: https://review.opendev.org/c/openstack/designate-tempest-plugin/+/880681/2/designate_tempest_plugin/tests/scenario/v2/test_recordsets.py#b168\nSuch an \"ddt unrolling\" increases the numbers of code lines and I\u0027m not sure it worth.\n\nBTW we have a similar implementation in other places, for example:\nhttps://review.opendev.org/c/openstack/designate-tempest-plugin/+/880681/2/designate_tempest_plugin/tests/scenario/v2/test_recordsets.py#86\nAlso some APIs test doing the same.\n\nThanks!", + "revId": "a5ba980ef4840a13032098bc583d556bbdef2b94", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file