{ "comments": [ { "unresolved": false, "key": { "uuid": "8aec489e_7bda633c", "filename": "/PATCHSET_LEVEL", "patchSetId": 1 }, "lineNbr": 0, "author": { "id": 28609 }, "writtenOn": "2023-11-21T13:10:15Z", "side": 1, "message": "recheck\n\nFailures seems to be related to \"notify\" issue, recheck the results.", "revId": "2c4210966b1458ed1a35c065c448f168f11c7277", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "ed73692a_b1f0480a", "filename": "/PATCHSET_LEVEL", "patchSetId": 1 }, "lineNbr": 0, "author": { "id": 28609 }, "writtenOn": "2023-11-26T15:08:04Z", "side": 1, "message": "recheck", "revId": "2c4210966b1458ed1a35c065c448f168f11c7277", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "846ac446_0899f72d", "filename": "/PATCHSET_LEVEL", "patchSetId": 1 }, "lineNbr": 0, "author": { "id": 30674 }, "writtenOn": "2023-11-30T10:57:36Z", "side": 1, "message": "Looks good to me! I would just add the negative attribute for the test.", "revId": "2c4210966b1458ed1a35c065c448f168f11c7277", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "b9d8b127_d02d08b9", "filename": "/PATCHSET_LEVEL", "patchSetId": 1 }, "lineNbr": 0, "author": { "id": 31664 }, "writtenOn": "2023-12-04T12:25:23Z", "side": 1, "message": "Looks good to me", "revId": "2c4210966b1458ed1a35c065c448f168f11c7277", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "100f6250_6b9099a4", "filename": "/PATCHSET_LEVEL", "patchSetId": 1 }, "lineNbr": 0, "author": { "id": 34067 }, "writtenOn": "2023-12-04T13:16:09Z", "side": 1, "message": "LGTM", "revId": "2c4210966b1458ed1a35c065c448f168f11c7277", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": false, "key": { "uuid": "0405abe7_cbd73eec", "filename": "/PATCHSET_LEVEL", "patchSetId": 1 }, "lineNbr": 0, "author": { "id": 11628 }, "writtenOn": "2024-01-08T22:07:49Z", "side": 1, "message": "LGTM", "revId": "2c4210966b1458ed1a35c065c448f168f11c7277", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, { "unresolved": true, "key": { "uuid": "4524faa4_b1515596", "filename": "designate_tempest_plugin/tests/api/v2/test_zones.py", "patchSetId": 1 }, "lineNbr": 747, "author": { "id": 30674 }, "writtenOn": "2023-11-30T10:57:36Z", "side": 1, "message": "Negative tests in tempest should have the attribute \u0027negative\u0027 [1]. But I see that the other negative tests here are missing the flag as well.\n\n[1] https://docs.openstack.org/tempest/latest/HACKING.html#negative-attribute", "range": { "startLine": 747, "startChar": 0, "endLine": 747, "endChar": 2 }, "revId": "2c4210966b1458ed1a35c065c448f168f11c7277", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] }