From e70af61dac1794ecd858c875c44d6b2ab0d59206 Mon Sep 17 00:00:00 2001 From: Takahito Hirose Date: Thu, 4 Jul 2019 20:45:18 +0900 Subject: [PATCH] Improve log message for better understanding Sometimes designate central could not update the Pool configuration. Very limited information is logged into the designate central logs through which we can not find the root cause of failure. This patch adds some more information into the log for better understanding. Change-Id: I26d36c15406436bb3b733d44c490a14e5ece39a6 Closes-Bug: 1835407 --- designate/manage/pool.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/designate/manage/pool.py b/designate/manage/pool.py index 6dabc6e8e..b478c9879 100644 --- a/designate/manage/pool.py +++ b/designate/manage/pool.py @@ -139,9 +139,10 @@ class PoolCommands(base.Commands): try: pool = self.central_api.get_pool( self.context, xpool['id']) - except Exception: - LOG.critical("Bad ID Supplied for pool %s", - xpool['name']) + except Exception as e: + msg = ("Bad ID Supplied for pool. pool_id: " + "%(pool)s message: %(res)s") + LOG.critical(msg, {'pool': xpool['id'], 'res': e}) continue else: pool = self.central_api.find_pool(