openstack/designate
Code Issues Proposed changes

Add basic storage test to test config overrides

Browse Source 
Basic test coverage for overriding the default_ttl for
zone creation.

Change-Id: Ic977f8c3986a0c24d43db1f3899a508620096c03
This commit is contained in:
Erik Olof Gunnar Andersson 2023-11-16 07:58:53 -08:00
parent aae83d09b8
commit 12362a234f
2 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
designate/tests/test_central/test_service.py
View File

@ -533,6 +533,37 @@ class CentralServiceTest(designate.tests.TestCase):
self.assertEqual(exceptions.OverQuota, exc.exc_info[0])
def test_create_zone_custom_ttl(self):
self.config(default_ttl=30)
values = dict(
name='example.com.',
email='info@example.com',
type='PRIMARY',
ttl=90,
)
zone = self.central_service.create_zone(
self.admin_context, zone=objects.Zone.from_dict(values)
)
self.assertEqual(90, zone.ttl)
def test_create_zone_override_default_ttl(self):
self.config(default_ttl=30)
values = dict(
name='example.com.',
email='info@example.com',
type='PRIMARY'
)
zone = self.central_service.create_zone(
self.admin_context, zone=objects.Zone.from_dict(values)
)
self.assertEqual(30, zone.ttl)
def test_create_subzone(self):
# Create the Parent Zone using fixture 0
parent_zone = self.create_zone(fixture=0)

30
designate/tests/test_storage/test_storage.py
View File

@ -683,6 +683,36 @@ class SqlalchemyStorageTest(TestCase):
self.assertEqual(exceptions.DuplicateZone, exc.exc_info[0])
def test_create_zone_standard_ttl(self):
values = self.get_zone_fixture()
new_zone = self.storage.create_zone(
self.admin_context, zone=objects.Zone.from_dict(values)
)
# default fallback ttl is 3600 when no ttl value is provided.
self.assertEqual(3600, new_zone.ttl)
def test_create_zone_custom_ttl(self):
self.config(default_ttl=60)
values = self.get_zone_fixture()
values['ttl'] = 30
new_zone = self.storage.create_zone(
self.admin_context, zone=objects.Zone.from_dict(values)
)
self.assertEqual(30, new_zone.ttl)
def test_create_zone_override_default_ttl(self):
self.config(default_ttl=60)
values = self.get_zone_fixture()
new_zone = self.storage.create_zone(
self.admin_context, zone=objects.Zone.from_dict(values)
)
self.assertEqual(60, new_zone.ttl)
def test_find_zones(self):
self.config(quota_zones=20)