openstack/designate
Code Issues Proposed changes

Make update_status use synchronized_zone

Browse Source 
There is a race condition when adding a new recordset to a zone
and when central is processing the update_status from a previous
recordset/zone operation. In the subsequent recordset operation,
central fails to update the zone's action/status in DB to UPDATE/PENDING.
It remains as NONE/ACTIVE, and worker error's out.

Each operation retrieves a different copy in memory of the Zone object
(when it calls self.storage.get_zone). As a result this does not update
the obj_changes field for the zone object for the latter operation.
Therefore the DB update doesn't update any values.

update_status should be synchronized as it updates zone DB

Change-Id: Ib4e0bc567ba8eb54c61c3921d165521bf2f12206
Closes-Bug: #1713875
This commit is contained in:
Arjun Baindur 2018-07-31 14:36:32 -07:00
parent 116d0a4b8e
commit 12cd654b14
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
designate/central/service.py
View File

@ -2302,6 +2302,7 @@ class Service(service.RPCService, service.Service):
@notification('dns.domain.update') @notification('dns.domain.update')
@notification('dns.zone.update') @notification('dns.zone.update')
@transaction @transaction
@synchronized_zone()
def update_status(self, context, zone_id, status, serial): def update_status(self, context, zone_id, status, serial):
""" """
:param context: Security context information. :param context: Security context information.