openstack/designate
Code Issues Proposed changes

Ensure partial API updates are validated correctly

Browse Source 
Change-Id: Id8123a780131989e5a0f36da478c3d34e21db209
This commit is contained in:
Kiall Mac Innes 2012-12-11 07:12:10 -08:00
parent cecd0f43bb
commit 14ec287902
3 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
moniker/api/v1/domains.py
View File

@ -98,7 +98,10 @@ def update_domain(domain_id):
values = flask.request.json values = flask.request.json
try: try:
domain_schema.validate(values) domain = central_api.get_domain(context, domain_id)
domain.update(values)
domain_schema.validate(domain)
domain = central_api.update_domain(context, domain_id, values) domain = central_api.update_domain(context, domain_id, values)
except exceptions.Forbidden: except exceptions.Forbidden:
return flask.Response(status=401) return flask.Response(status=401)

5
moniker/api/v1/records.py
View File

@ -98,7 +98,10 @@ def update_record(domain_id, record_id):
values = flask.request.json values = flask.request.json
try: try:
record_schema.validate(values) record = central_api.get_record(context, domain_id, record_id)
record.update(values)
record_schema.validate(record)
record = central_api.update_record(context, domain_id, record_id, record = central_api.update_record(context, domain_id, record_id,
values) values)
except exceptions.Forbidden: except exceptions.Forbidden:

5
moniker/api/v1/servers.py
View File

@ -97,7 +97,10 @@ def update_server(server_id):
values = flask.request.json values = flask.request.json
try: try:
server_schema.validate(values) server = central_api.get_server(context, server_id)
server.update(values)
server_schema.validate(server)
server = central_api.update_server(context, server_id, values=values) server = central_api.update_server(context, server_id, values=values)
except exceptions.Forbidden: except exceptions.Forbidden:
return flask.Response(status=401) return flask.Response(status=401)