openstack
/
designate
Code Issues Proposed changes

Add some additional logging for failing task test 

Change-Id: If81186c42f522a4d429b492e22ad66388fc25a5f
This commit is contained in:
Erik Olof Gunnar Andersson 2019-06-28 11:03:40 -07:00
parent 08684a2c8e
commit 1f97fab5de
2 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
designate/producer/tasks.py
View File

@ -263,12 +263,13 @@ class PeriodicGenerateDelayedNotifyTask(PeriodicTask):
'start': pstart,
'end': pend,
'n': len(zones)
})
}
)
for z in zones:
self.zone_api.update_zone(ctxt, z)
z.delayed_notify = False
self.central_api.update_zone(ctxt, z)
for zone in zones:
self.zone_api.update_zone(ctxt, zone)
zone.delayed_notify = False
self.central_api.update_zone(ctxt, zone)
class WorkerPeriodicRecovery(PeriodicTask):

12
designate/tests/test_producer/test_tasks.py
View File

@ -114,6 +114,10 @@ class PeriodicGenerateDelayedNotifyTaskTest(TestCase):
)
)
def _fetch_all_zones(self):
# Fetch all zones including deleted ones.
return self._fetch_zones(tables.zones.select())
def _fetch_zones(self, query):
# Fetch zones including deleted ones.
return self.central_service.storage.session.execute(query).fetchall()
@ -132,6 +136,9 @@ class PeriodicGenerateDelayedNotifyTaskTest(TestCase):
# Create zones and set some of them as pending update.
self._create_zones()
zones = self._fetch_all_zones()
self.assertEqual(self.number_of_zones, len(zones))
for remaining in reversed(range(0,
self.number_of_zones // 2,
self.batch_size)):
@ -140,4 +147,7 @@ class PeriodicGenerateDelayedNotifyTaskTest(TestCase):
zones = self._fetch_zones(tables.zones.select().where(
tables.zones.c.delayed_notify))
self.assertEqual(remaining, len(zones))
self.assertEqual(
remaining, len(zones),
message='Remaining zones: %s' % zones
)