openstack
/
designate
Code Issues Proposed changes

Drop setcap on python binary 

This is a bit of a security issue, also we don't seem to need it anymore
since we have long switched to running under python3 and the setcap
doesn't have any effect anyway. It will also break deployments once we
drop installing python2 completely, so just remove it now.

Change-Id: I7265c525f1091012011ba12d65e9669a826ab979
This commit is contained in:
Dr. Jens Harbott 2020-01-29 15:35:25 +00:00
parent f355aae939
commit 3770b006d0
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
devstack/plugin.sh
View File

@ -238,10 +238,6 @@ function create_designate_pool_configuration {
# init_designate - Initialize etc.
function init_designate {
# Some Designate Backends require mdns be bound to port 53, make that
# doable.
sudo setcap 'cap_net_bind_service=+ep' $(readlink -f /usr/bin/python)
# (Re)create designate database
recreate_database designate utf8
@ -259,12 +255,9 @@ function install_designate {
install_apache_wsgi
fi
if is_ubuntu; then
install_package libcap2-bin
elif is_fedora; then
if is_fedora; then
# bind-utils package provides `dig`
install_package libcap bind-utils
install_package bind-utils
fi
git_clone $DESIGNATE_REPO $DESIGNATE_DIR $DESIGNATE_BRANCH