From 709c842502875e3408c9fd2f8c1506af32ca9db2 Mon Sep 17 00:00:00 2001 From: caoyue Date: Sat, 16 Jan 2016 15:43:11 +0800 Subject: [PATCH] test: make enforce_type=True in CONF.set_override each config option has limitation for type and value. In production code, oslo.conf can ensure user's input is valid, but in unit test, test methods can pass if we use method CONF.set_override without parameter enforce_type=True even we pass wrong type or wrong value to config option. This commit makes sure calling method CONF.set_override with enforce_type=True Change-Id: Ia1511c1e1db53c83c8745134804aa09c7d2a3408 Related-Bug: #1517839 --- designate/tests/unit/test_central/test_basic.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/designate/tests/unit/test_central/test_basic.py b/designate/tests/unit/test_central/test_basic.py index 56420ae15..8c487f500 100644 --- a/designate/tests/unit/test_central/test_basic.py +++ b/designate/tests/unit/test_central/test_basic.py @@ -313,7 +313,8 @@ class CentralServiceTestCase(CentralBasic): self.assertTrue(designate.central.service.storage.get_storage.called) def test__is_valid_ttl(self): - self.CONF.set_override('min_ttl', 10, 'service:central') + self.CONF.set_override('min_ttl', 10, 'service:central', + enforce_type=True) self.service._is_valid_ttl(self.context, 20) # policy.check() not to raise: the user is allowed to create low TTLs