Use assertTrue/False instead of assertEqual(T/F)

Usage of assertEqual(True/False, ***) should be changed to a more
meaningful format of assertTrue/False(***).

Change-Id: I8623f5534f00ea1690f74a297488957a8d35f074
Closes-Bug: #1510001

designate/tests/test_coordination.py

@@ -42,7 +42,7 @@ class TestCoordinationMixin(TestCase):
         service = CoordinatedService()
         service.start()
 
-        self.assertEqual(True, service._coordination_started)
+        self.assertTrue(service._coordination_started)
         self.assertIn(service.service_name.encode('utf-8'),
                       service._coordinator.get_groups().get())
         self.assertIn(service._coordination_id.encode('utf-8'),
@@ -54,7 +54,7 @@ class TestCoordinationMixin(TestCase):
         service = CoordinatedService()
         service.start()
         service.stop()
-        self.assertEqual(False, service._coordination_started)
+        self.assertFalse(service._coordination_started)
 
     def test_start_no_coordination(self):
         self.config(backend_url=None, group="coordination")

designate/tests/test_dnsutils.py

@@ -106,16 +106,16 @@ class TestUtils(TestCase):
 
         # Ensure there's no lock for different zones
         for zone_name in ['foo.com.', 'bar.com.', 'example.com.']:
-            self.assertEqual(True, lock.acquire(zone_name))
+            self.assertTrue(lock.acquire(zone_name))
 
         # Ensure a lock for successive calls for the same zone
-        self.assertEqual(True, lock.acquire('example2.com.'))
-        self.assertEqual(False, lock.acquire('example2.com.'))
+        self.assertTrue(lock.acquire('example2.com.'))
+        self.assertFalse(lock.acquire('example2.com.'))
 
         # Acquire, release, and reacquire
-        self.assertEqual(True, lock.acquire('example3.com.'))
+        self.assertTrue(lock.acquire('example3.com.'))
         lock.release('example3.com.')
-        self.assertEqual(True, lock.acquire('example3.com.'))
+        self.assertTrue(lock.acquire('example3.com.'))
 
     def test_limit_notify_middleware(self):
         # Set the delay

designate/tests/test_pool_manager/test_service.py

@@ -173,7 +173,7 @@ class PoolManagerServiceNoopTest(PoolManagerTestCase):
 
         # Since consensus is not reached this early, we immediatly call
         # central's update_status.
-        self.assertEqual(True, mock_update_status.called)
+        self.assertTrue(mock_update_status.called)
 
     @patch.object(mdns_rpcapi.MdnsAPI, 'get_serial_number',
                   side_effect=messaging.MessagingException)
@@ -197,7 +197,7 @@ class PoolManagerServiceNoopTest(PoolManagerTestCase):
 
         # Since consensus is not reached this early, we immediatly call
         # central's update_status.
-        self.assertEqual(True, mock_update_status.called)
+        self.assertTrue(mock_update_status.called)
 
     @patch.object(mdns_rpcapi.MdnsAPI, 'get_serial_number',
                   side_effect=messaging.MessagingException)

designate/tests/test_storage/__init__.py

@@ -1495,14 +1495,14 @@ class StorageTestCase(object):
     def test_ping(self):
         pong = self.storage.ping(self.admin_context)
 
-        self.assertEqual(pong['status'], True)
+        self.assertTrue(pong['status'])
         self.assertIsNotNone(pong['rtt'])
 
     def test_ping_fail(self):
         with mock.patch.object(self.storage.engine, "execute",
                                side_effect=Exception):
             result = self.storage.ping(self.admin_context)
-            self.assertEqual(False, result['status'])
+            self.assertFalse(result['status'])
             self.assertIsNotNone(result['rtt'])
 
     # TLD Tests

designate/tests/test_storage/test_sqlalchemy.py

@@ -34,5 +34,5 @@ class SqlalchemyStorageTest(StorageTestCase, TestCase):
                                return_value=0):
             pong = self.storage.ping(self.admin_context)
 
-            self.assertEqual(pong['status'], False)
+            self.assertFalse(pong['status'])
             self.assertIsNotNone(pong['rtt'])

designate/tests/unit/test_api/test_middleware.py

@@ -90,7 +90,7 @@ class KeystoneContextMiddlewareTest(oslotest.base.BaseTestCase):
         self.app(self.request)
 
         self.assertFalse('all_tenants' in self.request.params)
-        self.assertEqual(self.ctxt.all_tenants, True)
+        self.assertTrue(self.ctxt.all_tenants)
 
     def test_all_tenants_in_params(self):
         self.request.headers.update({
@@ -102,7 +102,7 @@ class KeystoneContextMiddlewareTest(oslotest.base.BaseTestCase):
         self.app(self.request)
 
         self.assertFalse('all_tenants' in self.request.params)
-        self.assertEqual(self.ctxt.all_tenants, True)
+        self.assertTrue(self.ctxt.all_tenants)
 
     def test_all_tenants_not_set(self):
         self.request.headers.update({

designate/tests/unit/test_central/test_basic.py

@@ -400,7 +400,7 @@ class CentralServiceTestCase(CentralBasic):
         self.assertEqual(rset.type, 'SOA')
         self.assertEqual(rset.type, 'SOA')
         self.assertEqual(len(rset.records.objects), 1)
-        self.assertEqual(rset.records.objects[0].managed, True)
+        self.assertTrue(rset.records.objects[0].managed)
 
     def test__create_domain_in_storage(self):
         self.service._create_soa = Mock()

designate/tests/unit/test_objects/test_domain.py

@@ -77,7 +77,7 @@ class DomainTest(oslotest.base.BaseTestCase):
     def test_get_master_by_ip_none(self):
         domain = objects.Domain()
         m = domain.get_master_by_ip('2.0.0.0')
-        self.assertEqual(False, m)
+        self.assertFalse(m)
 
     def test_validate(self):
         domain = create_test_domain()

designate/tests/unit/test_zone_manager/test_tasks.py

@@ -199,7 +199,7 @@ class PeriodicExistsTest(TaskTest):
             iter_.return_value = []
             self.task()
 
-        self.assertEqual(False, self.mock_notifier.info.called)
+        self.assertFalse(self.mock_notifier.info.called)
 
     def test_emit_exists_multiple_zones(self):
         zones = [RoObject() for i in range(0, 10)]