openstack/designate
Code Issues Proposed changes

Fix order of argument in assertEqual

Browse Source 
Some tests of central used incorrect argument
order in assertEqual(observed, expected).
The correct order expected by testtools is
assertEqual(expected, observed)

Change-Id: I8fb43e687e64e133b23c1321659183a8b18c11f6
Partial-Bug: #1259292
This commit is contained in:
sonu.kumar 2015-10-16 14:39:21 +05:30
parent 027e3108e1
commit 6a29992833
1 changed files with 4 additions and 4 deletions

8
designate/tests/test_central/_test_service_ipa.py

@ -105,7 +105,7 @@ class CentralServiceTestIPA(designate.tests.test_central.
records = self.central_service.find_records(
self.admin_context, criterion)
self.assertEqual(len(records), 2)
self.assertEqual(2, len(records))
self.assertRecordsEqual(recA0, records[0])
self.assertRecordsEqual(recA1, records[1])
@ -114,7 +114,7 @@ class CentralServiceTestIPA(designate.tests.test_central.
records = self.central_service.find_records(
self.admin_context, criterion)
self.assertEqual(len(records), 2)
self.assertEqual(2, len(records))
self.assertRecordsEqual(recMX0, records[0])
self.assertRecordsEqual(recMX1, records[1])
@ -138,7 +138,7 @@ class CentralServiceTestIPA(designate.tests.test_central.
records = self.central_service.find_records(
self.admin_context, criterion)
self.assertEqual(len(records), 0)
self.assertEqual(0, len(records))
# verify two records in recsetMX
criterion['recordset_id'] = recsetMX['id']
@ -146,7 +146,7 @@ class CentralServiceTestIPA(designate.tests.test_central.
records = self.central_service.find_records(
self.admin_context, criterion)
self.assertEqual(len(records), 2)
self.assertEqual(2, len(records))
# Delete recsetMX
self.central_service.delete_recordset(