From 77d9f412d23c567a0b75550808081e52b6a74605 Mon Sep 17 00:00:00 2001 From: "sharat.sharma" Date: Mon, 23 May 2016 17:09:12 +0530 Subject: [PATCH] Modify assert statement when comparing with None Replace assertEqual(None, *) with assertIsNone in designate's tests to have more clear messages in case of failure. Change-Id: Iad1dee48bdb35b338e7b18bfb76c7f5e561c3790 Closes-Bug: #1280522 --- designate/tests/test_api/test_v2/test_service_status.py | 2 +- designate/tests/unit/test_agent/test_backends/test_knot2.py | 2 +- designate/tests/unit/test_backend/test_agent.py | 6 +++--- designate/tests/unit/test_mdns/test_handler.py | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/designate/tests/test_api/test_v2/test_service_status.py b/designate/tests/test_api/test_v2/test_service_status.py index 5877fc88a..cce470683 100644 --- a/designate/tests/test_api/test_v2/test_service_status.py +++ b/designate/tests/test_api/test_v2/test_service_status.py @@ -77,7 +77,7 @@ class ApiV2ServiceStatusTest(ApiV2TestCase): response.json['capabilities']) self.assertEqual(fixture['stats'], response.json['stats']) self.assertEqual(fixture['status'], response.json['status']) - self.assertEqual(None, response.json['heartbeated_at']) + self.assertIsNone(response.json['heartbeated_at']) def test_get_service_status_invalid_id(self): self.policy({'find_service_status': '@'}) diff --git a/designate/tests/unit/test_agent/test_backends/test_knot2.py b/designate/tests/unit/test_agent/test_backends/test_knot2.py index d315bee55..3d5bdb2d1 100644 --- a/designate/tests/unit/test_agent/test_backends/test_knot2.py +++ b/designate/tests/unit/test_agent/test_backends/test_knot2.py @@ -158,7 +158,7 @@ class Knot2AgentBackendUnitTestCase(TestCase): mock_exe.side_effect = ProcessExecutionError( "error: [example.com.] (no such zone found)") serial = self.kb.find_zone_serial('example.com') - self.assertEqual(None, serial) + self.assertIsNone(serial) @mock.patch('designate.backend.agent_backend.impl_knot2.execute') def test_find_zone_serial_unexpected_output(self, mock_exe): diff --git a/designate/tests/unit/test_backend/test_agent.py b/designate/tests/unit/test_backend/test_agent.py index f34b5d0bb..b18eb8cbd 100644 --- a/designate/tests/unit/test_backend/test_agent.py +++ b/designate/tests/unit/test_backend/test_agent.py @@ -65,7 +65,7 @@ class BackendAgentTest(base.BaseTestCase): self.agent._make_and_send_dns_message.assert_called_with( 'zn', 1, 14, pcodes.CREATE, pcodes.SUCCESS, 2, 3) - self.assertEqual(None, out) + self.assertIsNone(out) def test_create_zone_exception(self, *mock): self.agent._make_and_send_dns_message = Mock(return_value=(None, 2)) @@ -84,7 +84,7 @@ class BackendAgentTest(base.BaseTestCase): self.agent.mdns_api.notify_zone_changed.assert_called_with( 'ctx', zone, 2, 3, 1, 4, 5, 6) - self.assertEqual(None, out) + self.assertIsNone(out) def test_delete_zone(self, *mock): self.agent._make_and_send_dns_message = Mock(return_value=(1, 2)) @@ -93,7 +93,7 @@ class BackendAgentTest(base.BaseTestCase): self.agent._make_and_send_dns_message.assert_called_with( 'zn', 1, 14, pcodes.DELETE, pcodes.SUCCESS, 2, 3) - self.assertEqual(None, out) + self.assertIsNone(out) def test_delete_zone_exception(self, *mock): self.agent._make_and_send_dns_message = Mock(return_value=(None, 2)) diff --git a/designate/tests/unit/test_mdns/test_handler.py b/designate/tests/unit/test_mdns/test_handler.py index dd18b109a..5f34ae5c5 100644 --- a/designate/tests/unit/test_mdns/test_handler.py +++ b/designate/tests/unit/test_mdns/test_handler.py @@ -120,7 +120,7 @@ class TestRequestHandlerCall(unittest.TestCase): ) r_rrset = self.handler._convert_to_rrset(zone, recordset) - self.assertEqual(None, r_rrset) + self.assertIsNone(r_rrset) def test__convert_to_rrset(self): zone = objects.Zone.from_dict({'ttl': 1234})