openstack
/
designate
Code Issues Proposed changes

Replace assertDictEqual() with assertEqual() 

In unittesttools, assertDictEqual() and assertEqual()
are implemented by using '!=' operator. But assertEqual()
can handle dict, list, set and so on.
So we should use assertEqual() to make the test simpler.

TrivialFix.

Change-Id: Ie6a8087c3d81d54f99a38b5950ac1834a51cb8d1
This commit is contained in:
qinchunhua 2016-07-29 01:14:16 -04:00
parent addc6b0df8
commit 7cd1f611da
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
designate/tests/unit/test_api/test_admin_api.py
View File

@ -50,15 +50,15 @@ class TestAdminAPI(TestCase):
request = MockRequest(GET=dict(limit="max"))
links = bv._get_collection_links(request, item_list)
self.assertDictEqual(links, dict(self=None))
self.assertEqual(links, dict(self=None))
request = MockRequest(GET=dict(limit="MAX"))
links = bv._get_collection_links(request, item_list)
self.assertDictEqual(links, dict(self=None))
self.assertEqual(links, dict(self=None))
request = MockRequest(GET=dict(limit="200"))
links = bv._get_collection_links(request, item_list)
self.assertDictEqual(links, dict(self=None, next=None))
self.assertEqual(links, dict(self=None, next=None))
request = MockRequest(GET=dict(limit="BOGUS_STRING"))
self.assertRaises(

6
designate/tests/unit/test_api/test_api_v2.py
View File

@ -46,15 +46,15 @@ class TestAPIv2(TestCase):
item_list = range(200)
request = MockRequest(GET=dict(limit="max"))
links = base.APIv2Adapter._get_collection_links(item_list, request)
self.assertDictEqual(links, dict(self=None))
self.assertEqual(links, dict(self=None))
request = MockRequest(GET=dict(limit="MAX"))
links = base.APIv2Adapter._get_collection_links(item_list, request)
self.assertDictEqual(links, dict(self=None))
self.assertEqual(links, dict(self=None))
request = MockRequest(GET=dict(limit="200"))
links = base.APIv2Adapter._get_collection_links(item_list, request)
self.assertDictEqual(links, dict(self=None, next=None))
self.assertEqual(links, dict(self=None, next=None))
request = MockRequest(GET=dict(limit="BOGUS_STRING"))
self.assertRaises(