Replace assertDictEqual() with assertEqual()
In unittesttools, assertDictEqual() and assertEqual() are implemented by using '!=' operator. But assertEqual() can handle dict, list, set and so on. So we should use assertEqual() to make the test simpler. TrivialFix. Change-Id: Ie6a8087c3d81d54f99a38b5950ac1834a51cb8d1
This commit is contained in:
parent
addc6b0df8
commit
7cd1f611da
@ -50,15 +50,15 @@ class TestAdminAPI(TestCase):
|
||||
|
||||
request = MockRequest(GET=dict(limit="max"))
|
||||
links = bv._get_collection_links(request, item_list)
|
||||
self.assertDictEqual(links, dict(self=None))
|
||||
self.assertEqual(links, dict(self=None))
|
||||
|
||||
request = MockRequest(GET=dict(limit="MAX"))
|
||||
links = bv._get_collection_links(request, item_list)
|
||||
self.assertDictEqual(links, dict(self=None))
|
||||
self.assertEqual(links, dict(self=None))
|
||||
|
||||
request = MockRequest(GET=dict(limit="200"))
|
||||
links = bv._get_collection_links(request, item_list)
|
||||
self.assertDictEqual(links, dict(self=None, next=None))
|
||||
self.assertEqual(links, dict(self=None, next=None))
|
||||
|
||||
request = MockRequest(GET=dict(limit="BOGUS_STRING"))
|
||||
self.assertRaises(
|
||||
|
@ -46,15 +46,15 @@ class TestAPIv2(TestCase):
|
||||
item_list = range(200)
|
||||
request = MockRequest(GET=dict(limit="max"))
|
||||
links = base.APIv2Adapter._get_collection_links(item_list, request)
|
||||
self.assertDictEqual(links, dict(self=None))
|
||||
self.assertEqual(links, dict(self=None))
|
||||
|
||||
request = MockRequest(GET=dict(limit="MAX"))
|
||||
links = base.APIv2Adapter._get_collection_links(item_list, request)
|
||||
self.assertDictEqual(links, dict(self=None))
|
||||
self.assertEqual(links, dict(self=None))
|
||||
|
||||
request = MockRequest(GET=dict(limit="200"))
|
||||
links = base.APIv2Adapter._get_collection_links(item_list, request)
|
||||
self.assertDictEqual(links, dict(self=None, next=None))
|
||||
self.assertEqual(links, dict(self=None, next=None))
|
||||
|
||||
request = MockRequest(GET=dict(limit="BOGUS_STRING"))
|
||||
self.assertRaises(
|
||||
|
Loading…
Reference in New Issue
Block a user