openstack/designate
Code Issues Proposed changes

Fix a sqlalchemy 2.x compatibility issue

Browse Source 
A recent patch[1] introduced an incompatibility with sqlalchemy 2.x.
Unfortunately the upper-constraint of oslo.db < 13.0.0 blocks us from properly
testing with sqlalchemy 2.x, so this issue was not caught.

[1] https://review.opendev.org/c/openstack/designate/+/880514

Change-Id: Ibc0569235997ea1feb2341adc1e942ecb3fc6dcb
This commit is contained in:
Michael Johnson
2023-07-18 01:30:02 +00:00
parent 963751f2b4
commit 7daa2578a5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
designate/storage/sqlalchemy/base.py
+1 -1
View File
@@ -429,7 +429,7 @@ class SQLAlchemy(object, metaclass=abc.ABCMeta):
tables.records.c.recordset_id == tables.recordsets.c.id
)
query = select(RECORDSET_QUERY_TABLES).select_from(rjoin)
query = select(*RECORDSET_QUERY_TABLES).select_from(rjoin)
query = query.where(
tables.recordsets.c.id.in_(formatted_ids)