openstack/designate
Code Issues Proposed changes

Handle async Tooz calls appropriately

Browse Source 
he CoordinationMixin treats some async calls as synchronous, in
environments with high latency etc, this can result in out of
order operations causing failures.

Change-Id: Ic8ce8f08910681260ccb77f423ac1a8fa19d8bd1
Closes-Bug: 1566285
This commit is contained in:
Kiall Mac Innes 2016-04-05 13:04:07 +01:00
parent a28f616c5e
commit 909cc5d786
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
designate/coordination.py
View File

@ -83,8 +83,18 @@ class CoordinationMixin(object):
while not self._coordination_started:
try:
self._coordinator.start()
self._coordinator.create_group(self.service_name)
self._coordinator.join_group(self.service_name)
try:
create_group_req = self._coordinator.create_group(
self.service_name)
create_group_req.get()
except tooz.coordination.GroupAlreadyExist:
pass
join_group_req = self._coordinator.join_group(
self.service_name)
join_group_req.get()
self._coordination_started = True
except Exception:
@ -96,7 +106,8 @@ class CoordinationMixin(object):
if self._coordinator is not None:
self._coordination_started = False
self._coordinator.leave_group(self.service_name)
leave_group_req = self._coordinator.leave_group(self.service_name)
leave_group_req.get()
self._coordinator.stop()
super(CoordinationMixin, self).stop()